Fix the labels on addresses #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
fix-address-labels
branch
from
ca2b077 to
050df70
Compare
asmega
approved these changes
Sep 10, 2024
kenfodder
approved these changes
Sep 10, 2024
Labels on addresses were `for` `claim_some_address` but the radio button had the `id` `some_address`. Update the radio buttons to use govuk_radio_button helper and let that generate the label tag. Also updates the specs to click the labels rather than find the radio buttons by id.
rjlynch
force-pushed
the
fix-address-labels
branch
from
050df70 to
0767814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the labels on addresses
Labels on addresses were
forclaim_some_addressbut the radio buttonhad the
idsome_address. Update the radio buttons to usegovuk_radio_button helper and let that generate the label tag. Also
updates the specs to click the labels rather than find the radio buttons
by id.
walkthrough.mov