[LUPEYALPHA-954] FE admin tasks #3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmega
commented
Sep 6, 2024
| return unless awaiting_task? | ||
|
|
||
| no_data || no_match || matched | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def required? | ||
| claim.eligibility.teacher_reference_number.present? |
There was a problem hiding this comment.
not sure if this negatively impacts other policies?
There was a problem hiding this comment.
I think this should be ok, most of the other journeys require a TRN from the claimant to submit, IRP doesn't but it doesn't use this claim verifier
asmega
commented
Sep 6, 2024
Comment on lines
+29
to
+40
| def employment | ||
| [] | ||
| end | ||
|
|
||
| def identity_confirmation | ||
| [] | ||
| end | ||
|
|
||
| def student_loan_plan | ||
| [] | ||
| end | ||
|
|
rjlynch
approved these changes
Sep 6, 2024
| return unless awaiting_task? | ||
|
|
||
| no_data || no_match || matched | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def required? | ||
| claim.eligibility.teacher_reference_number.present? |
There was a problem hiding this comment.
I think this should be ok, most of the other journeys require a TRN from the claimant to submit, IRP doesn't but it doesn't use this claim verifier
| unless claim.policy.further_education_payments? | ||
| case policy | ||
| when Policies::FurtherEducationPayments | ||
| Policies::FurtherEducationPayments::ClaimCheckingTasks |
asmega
force-pushed
the
fe-admin-tasks
branch
2 times, most recently
from
7168d24 to
02c0999
Compare
asmega
force-pushed
the
fe-admin-tasks
branch
from
02c0999 to
f482e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context