Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rejection reasons for FE claims #3156

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Add rejection reasons for FE claims #3156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions app/models/policies/further_education_payments.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ module FurtherEducationPayments

# Options shown to admins when rejecting a claim
ADMIN_DECISION_REJECTED_REASONS = [
# FIXME RL: this `placeholder` is required to make the
# `spec/models/policies/further_education_payments/claim_personal_data_scrubber_spec.rb`
# test pass. Once we add a real rejection reason we can remove this
# placeholder. Figured this was better than removing the test!
:placeholder
:no_teaching_responsibilities,
:no_eligible_contract_of_employment,
:works_less_than_2_point_5_hours_per_week,
:has_worked_in_further_education_for_more_than_5_years,
:ineligible_subject_or_courses,
:insufficient_time_spent_teaching_eligibble_students,
:duplicate_claim,
:no_response,
:other
]

# TODO: This is needed once the reply-to email address has been added to Gov Notify
Expand Down
11 changes: 11 additions & 0 deletions config/locales/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,6 +836,17 @@ en:
url: "https://www.gov.uk/guidance/levelling-up-premium-payments-for-fe-teachers"
fe_provider_list_url: "https://assets.publishing.service.gov.uk/media/66d70f9c701781e1b341dba7/List_of_eligible_FE_providers_and_payment_values_for_targeted_retention_incentives.xlsx"
admin:
decision:
rejected_reasons:
no_teaching_responsibilities: "No teaching responsibilities"
no_eligible_contract_of_employment: "No eligible contract of employment"
works_less_than_2_point_5_hours_per_week: "Works less than 2.5 hours per week (either currently or next term)"
has_worked_in_further_education_for_more_than_5_years: "Has worked in further education for more than 5 years"
ineligible_subject_or_courses: "Ineligible subjects or courses"
insufficient_time_spent_teaching_eligibble_students: "Insufficient time spent teaching eligible students"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same eligibble typo is on notify so going to leave that for the minute!

duplicate_claim: "Duplicate claim"
no_response: "No response"
other: "Other"
task_questions:
matching_details:
title: Is this claim still valid despite having matching details with other claims?
Expand Down
Loading