Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-993] Cache OL data #3149

Merged
merged 4 commits into from
Sep 5, 2024
Merged

[LUPEYALPHA-993] Cache OL data #3149

merged 4 commits into from
Sep 5, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Sep 4, 2024 •
edited
Loading

Context

Changes

  • Moved a load of admin request specs into a folder aptly named /admin
  • On the journey session we now store the following extra
    • onelogin_auth_at - when user authenticated with OL
    • onelogin_idv_at - when user passed IDV
    • onelogin_idv_first_name, onelogin_idv_last_name, onelogin_idv_date_of_birth
  • All the above also get saved on the claim when claim is created at end of journey
  • We also at the same time store onelogin_uid on the claim which was already present in journey session
  • Bonus: we now pre-populate date of birth in personal details section with the value from one login

@asmega asmega changed the title Cache OL data [LUPEYALPHA-993] Cache OL data Sep 4, 2024
@asmega asmega marked this pull request as ready for review September 4, 2024 16:39
rjlynch
rjlynch approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Might be tempted to extract parsing the OL data into a form object but I it's fine as is 👍

@kenfodder kenfodder merged commit e7c4732 into master Sep 5, 2024
14 checks passed
@kenfodder kenfodder deleted the cache-ol-data branch September 5, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asmega @rjlynch @kenfodder