Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-977] Sign out link on mismatch organisation failure page #3146

Merged
merged 2 commits into from
Sep 5, 2024
Merged

[LUPEYALPHA-977] Sign out link on mismatch organisation failure page #3146

merged 2 commits into from
Sep 5, 2024

Conversation

kenfodder
Copy link
Contributor

@kenfodder kenfodder commented Sep 3, 2024 •
edited
Loading

  • Actually calls the DSI logout endpoint
  • Set a post logout redirect uri back to Claim
  • Grab the claim off the session and clears the session
  • Redirects to the verify url as if the user clicked on it again
  • Added a new flash[:success] and a message to say signed out

UPDATE:

  • Sign out button moved to the bottom
  • Flash success design

Screenshot 2024-09-04 at 16 08 04

Screenshot 2024-09-04 at 16 08 12

@kenfodder kenfodder force-pushed the fe-provider-sign-out-dsi branch 2 times, most recently from 3d79203 to 8e220ed Compare September 3, 2024 19:18
@kenfodder kenfodder added the deploy Deploy a review app for this PR label Sep 3, 2024
@kenfodder kenfodder marked this pull request as ready for review September 3, 2024 19:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/early-years-payment/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3146-web.test.teacherservices.cloud/admin

@alkesh alkesh changed the title Sign out link on mismatch organisation failure page [LUPEYALPHA-977] Sign out link on mismatch organisation failure page Sep 4, 2024
@kenfodder kenfodder force-pushed the fe-provider-sign-out-dsi branch from 8e220ed to 31e98f4 Compare September 4, 2024 14:53
@kenfodder kenfodder requested a review from rjlynch September 4, 2024 15:06
@kenfodder
Copy link
Contributor Author

@rjlynch Updated with the session clearing and redirect to the verify url: 31e98f4

@kenfodder kenfodder force-pushed the fe-provider-sign-out-dsi branch from 18846e9 to 8c5731b Compare September 5, 2024 10:02
@kenfodder
LUPEYALPHA-977 - Sign out link on mismatch organisation failure page
bacb8a8 
* Actually calls the DSI logout endpoint
* Set a post logout redirect uri back to Claim
* Grab the claim off the session and clears the session
* Redirects to the verify url as if the user clicked on it again
* Added a new flash[:success] and a message to say signed out
@kenfodder
Clear the session, redirect to the verify url and add new flash[:succ…
70b8625 
…ess] in layout
@kenfodder kenfodder force-pushed the fe-provider-sign-out-dsi branch from 8c5731b to 70b8625 Compare September 5, 2024 11:08
@kenfodder kenfodder merged commit cbef563 into master Sep 5, 2024
14 checks passed
@kenfodder kenfodder deleted the fe-provider-sign-out-dsi branch September 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmega asmega asmega approved these changes

@slorek slorek Awaiting requested review from slorek

@rjlynch rjlynch Awaiting requested review from rjlynch

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenfodder @asmega @rjlynch