Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider confirmation email #3139

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Aug 30, 2024

When the provider has verified the claim we want to email their
organisation with a confirmation email, letting them know a claim has
been verified and who did it.

Also fixes the have_received_email_matcher to show the template id if
a match cant be found.

@@ -164,13 +191,26 @@
],
"verifier" => {
"dfe_sign_in_uid" => "123",
"first_name" => "Seymoure",
"first_name" => "Seymour",
"last_name" => "Skinner",
"email" => "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@rjlynch rjlynch force-pushed the LUPEYALPHA-843/provider-confirmation-email branch from 2542420 to effa6a4 Compare August 30, 2024 13:52
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Aug 30, 2024
app/mailers/claim_mailer.rb Outdated Show resolved Hide resolved
@rjlynch rjlynch force-pushed the LUPEYALPHA-843/provider-confirmation-email branch from effa6a4 to cafa127 Compare August 30, 2024 14:17
@rjlynch rjlynch requested a review from slorek September 2, 2024 08:46
@rjlynch rjlynch force-pushed the LUPEYALPHA-843/provider-confirmation-email branch from cafa127 to ddcb85a Compare September 5, 2024 10:34
@rjlynch rjlynch force-pushed the LUPEYALPHA-843/provider-confirmation-email branch from ddcb85a to 5a5fc46 Compare September 6, 2024 12:27
When the provider has verified the claim we want to email their
organisation with a confirmation email, letting them know a claim has
been verified and who did it.

Also fixes the `have_received_email_matcher` to show the template id if
a match cant be found.
@rjlynch rjlynch force-pushed the LUPEYALPHA-843/provider-confirmation-email branch 2 times, most recently from 41b309e to 013ca26 Compare September 6, 2024 13:19
@rjlynch rjlynch merged commit 6b0df12 into master Sep 6, 2024
11 checks passed
@rjlynch rjlynch deleted the LUPEYALPHA-843/provider-confirmation-email branch September 6, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants