admin provider verification task #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
admin-provider-verification-task
branch
from
87a9693 to
e8b4dee
Compare
rjlynch
changed the base branch from
fe-provider-dsi-bypass
to
send-verification-request-to-provider
rjlynch
force-pushed
the
send-verification-request-to-provider
branch
from
20c20b0 to
a861811
Compare
Base automatically changed from
send-verification-request-to-provider
to
master
August 29, 2024 09:03
rjlynch
force-pushed
the
admin-provider-verification-task
branch
5 times, most recently
from
5dc7af3 to
240218f
Compare
slorek
approved these changes
Sep 3, 2024
rjlynch
force-pushed
the
admin-provider-verification-task
branch
2 times, most recently
from
850afdf to
3539374
Compare
Renames the `hours_teaching_eligible_subjects` key to `half_teaching_hours` as `half_teaching_hours` maps to the question shown to the claimant.
Adds the admin task for reviewing the provider's verification of the claimant's claim. This task is currently a manual check by the admin but in a future iteration will be replaced with an automated check. There isn't a design for the manual check yet but all the other checks use a yes / no radio button so we've gone for that, the copy for the admin question may be suject to change. There's a bit of awkwardness in presenting the verification table as there questions the provider signs off on are slightly different to those shown in the admin task. Rather than clutter the admin_tasks_presenter, which will handle showing information about other tasks, the admin task presenter calls a specific verification presenter to handle displaying the verification table. Some of this code feels a bit awkward, maybe we need to consider moving the verification json into and object.
Captures the organisation name from DfE sign in, we'll want to know this if we're creating `DfeSignIn::User` records for the providers.
When we create the verification record we want to also capture the organisation and roles as we'll be using the verification to create a DfeSignIn::User record which expects these fields.
If the provider has verified all the information provider by the client we want to mark the task as passed. If the provider hasn't verified all the information from the client we want to mark the task as failed. Tasks are associated with a `DfeSignIn::User` so we need to create one of these for the provider. NOTE that the find_or_create includes the organisation check, we may have providers with multiple organisations, in such cases we'll create a duplicate record for them. The DfeSignIn::User only has a single organisation so if we want to record the organisation the user was logged in as we can't really avoid duplicate users here.
rjlynch
force-pushed
the
admin-provider-verification-task
branch
from
3539374 to
e67efa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the admin provider verification task.
Probably best to review each commit separately, the main ones are
I've used the existing claim verifier mechanism to handle calling the provider verification task, this means the claim verifier code will be run twice for the same claim, once when the claimant submits the claim and once when the provider verifies it. If there's an issue with he claim verifier code being ran twice that I've overlooked, let me know, can always create the task directly in the verification form.
Walk through
walk-through.mov