Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fe provider dsi bypass #3116

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fe provider dsi bypass #3116

merged 1 commit into from
Aug 30, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Aug 22, 2024

Add DfE sign in by pass

In review apps we can't use DfE sign in as the urls are dynamic and so
are not registered with DfE sign in. This commit provides a form to
allow testers to set the DfE sign in payload to check various sign in
scenarios.

Screenshot 2024-08-29 at 10 37 57

@rjlynch rjlynch changed the base branch from master to send-verification-request-to-provider August 22, 2024 16:25
@rjlynch rjlynch force-pushed the fe-provider-dsi-bypass branch from 147c93f to 4403d71 Compare August 22, 2024 16:27
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Aug 22, 2024
@rjlynch rjlynch removed the deploy Deploy a review app for this PR label Aug 23, 2024
@rjlynch rjlynch added the deploy Deploy a review app for this PR label Aug 23, 2024
@rjlynch rjlynch force-pushed the send-verification-request-to-provider branch 3 times, most recently from 20c20b0 to a861811 Compare August 29, 2024 08:57
Base automatically changed from send-verification-request-to-provider to master August 29, 2024 09:03
@rjlynch rjlynch force-pushed the fe-provider-dsi-bypass branch from 4403d71 to e6d0f11 Compare August 29, 2024 09:04
@rjlynch rjlynch force-pushed the fe-provider-dsi-bypass branch from e6d0f11 to bd4782b Compare August 29, 2024 09:38
@rjlynch rjlynch marked this pull request as ready for review August 29, 2024 09:41
@rjlynch
Copy link
Contributor Author

rjlynch commented Aug 29, 2024

I'd investigated using the developer oauth strategy but it only lets us set top level fields, can't set extra attributes, and it was too much of a faff to add support for more fields so decided to just use a form and add a branch on whether DSI is enabled. Patching the dev strategy is probably better long term, may be worth sending up a PR to them

In review apps we can't use DfE sign in as the urls are generic and so
are not registered with DfE sign in. This commit providers a form to
allow testers to set the DfE sign in payload to check various sign in
scenarios.
@rjlynch rjlynch force-pushed the fe-provider-dsi-bypass branch from 3ea2bf1 to fc3ebfd Compare August 30, 2024 13:48
@rjlynch rjlynch merged commit d5bb7a9 into master Aug 30, 2024
12 checks passed
@rjlynch rjlynch deleted the fe-provider-dsi-bypass branch August 30, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploy a review app for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants