Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LUPEYALPHA-763] EY Declaration of consent page #3048

Merged
merged 2 commits into from
Aug 2, 2024
Merged

[LUPEYALPHA-763] EY Declaration of consent page #3048

merged 2 commits into from
Aug 2, 2024

Conversation

AbigailMcP
Copy link
Contributor

@AbigailMcP AbigailMcP commented Jul 31, 2024 •
edited
Loading

Changes in this PR

  • New ConsentForm with presence validation on :consent_given attribute
  • Form spec and extension of happy path feature test
  • Basic ClaimSubmissionForm which is required for the page sequence to work - it checks claim_submittable?

Notes

  • We've skipped the email address form for now until we finish the whitelisting work

Guidance to review

  • Head to the EY landing page (link in review app comment below)
  • Click 'Start now'
  • Check the declaration of consent page against the prototype
  • Click 'Continue' with the checkbox unchecked
  • Check that you get the correct error message
  • Check the checkbox and press 'Continue'
  • Check that you progress to the 'current-nursery' page (currently empty)
Screenshot 2024-07-31 at 13 53 48 Screenshot 2024-07-31 at 13 53 50

@AbigailMcP AbigailMcP marked this pull request as ready for review July 31, 2024 12:57
@AbigailMcP AbigailMcP added the deploy Deploy a review app for this PR label Jul 31, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/further-education-payments/landing-page
Early Years Payment https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/early-years-payment-provider/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3048-web.test.teacherservices.cloud/admin

rjlynch
rjlynch approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

app/forms/journeys/early_years_payment/provider/claim_submission_form.rb
def calculate_award_amount(eligibility)
# NOOP
# This is just for compatibility with the AdditionalPaymentsForTeaching
# claim submission form.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this description as we're now using calculate_award_amount for IRP claims too - obv not a blocker!

@AbigailMcP AbigailMcP requested a review from vacabor August 1, 2024 09:11
@AbigailMcP
Declaration of consent page
201bebd 
- Add new ConsentForm with presence validation on :consent_given attr
- Add form spec and extend happy_path feature test
- Add basic ClaimSubmissionForm which is required
@AbigailMcP
Wrap form content inside govuk-hint
d9bee06 
Together with setting the form heading as the legend, this ensures the
error message appears directly above the checkbox field itself
@AbigailMcP AbigailMcP force-pushed the LUPEYALPHA-763-ey-declaration-of-employee-consent branch from fd29891 to d9bee06 Compare August 2, 2024 10:33
@AbigailMcP AbigailMcP merged commit 91781ba into master Aug 2, 2024
14 checks passed
@AbigailMcP AbigailMcP deleted the LUPEYALPHA-763-ey-declaration-of-employee-consent branch August 2, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

@vacabor vacabor Awaiting requested review from vacabor

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbigailMcP @rjlynch