ignore session answer attributes in the stored JSON that have not been defined on the SessionAnswers class #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
approved these changes
Jul 29, 2024
| @@ -12,7 +12,10 @@ def cast_value(value) | |||
| rescue | |||
| nil | |||
| end | |||
| answers_class.new(decoded) unless decoded.nil? | |||
| unless decoded.nil? | |||
vacabor
approved these changes
Jul 29, 2024
alkesh
force-pushed
the
ignore-undefined-session-answer-attributes
branch
from
7982f1a to
14f4073
Compare
…n defined on the SessionAnswers class
alkesh
force-pushed
the
ignore-undefined-session-answer-attributes
branch
from
14f4073 to
a8121fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, an
UnknownAttributeErroris raised on any page in the journey, hence breaking the app totally, in the following scenarios:Journeys::SessionAnswers, deployed it, but then want to roll back that deploymentJourneys::SessionAnswersand deploy thatThere is a workaround that doesn't involve this change - and that is to purge all journey sessions.
This change would mean that is no longer necessary.