CAPT-1531 Notify emails #3034
Merged
CAPT-1531 Notify emails #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
force-pushed
the
CAPT-1531/irp-notify-emails
branch
from
21e781d to
9762ba4
Compare
rjlynch
force-pushed
the
CAPT-1531/irp-notify-emails
branch
from
9762ba4 to
7188a34
Compare
rjlynch
force-pushed
the
CAPT-1531/irp-notify-emails
branch
from
211e7b6 to
b43cdce
Compare
rjlynch
changed the title
rjlynch
changed the title
rjlynch
changed the title
asmega
approved these changes
Aug 1, 2024
kenfodder
approved these changes
Aug 1, 2024
Different policies have different rejection reasons. While the rejection reasons for ECP, LUP, and TSLR are similar (ECP has an extra reason), future policies (specifically IRP) have different rejection reasons. This commit moves the available rejection reasons into a constant in the policy, so new policies can just add their reasons there and update the locales file.
Adds the rejection reasons given in the ticket. I've also updated the notify email rejection template to work with these reasons.
Want to make sure the claim mailer specs cover irp emails. IRP emails currenlty don't have a notify reply to id so we've added a safe navigation operator to the "reply_to_id" field.
Adds two more rejection options to IRP
When running the personal data scrubber spec we create a `Decision` instance. A `Decision` requires a rejection reason to be valid. The rejection reason is taken from the `Decision`'s `Claim`'s policy'. To avoid needing to remove / disable the test, and risk not reintroducing it, we've added a temporary `placeholder` rejection reason (the other option was stubbing the `ADMIN_DECISION_REJECTED_REASONS` constant in the spec). When we get round to adding the rejection reasons for FE we can remove this place holder and the tests will work with whatever is the first value in the `ADMIN_DECISION_REJECTED_REASONS` constant.
rjlynch
force-pushed
the
CAPT-1531/irp-notify-emails
branch
from
abd4f3e to
f7d9cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different policies have different rejection reasons. While the rejection
reasons for ECP, LUP, and TSLR are similar (ECP has an extra reason),
future policies (specifically IRP) have different rejection reasons.
This PR moves the available rejection reasons into a constant in the
policy, so new policies can just add their reasons there and update the
locales file.
Notes for review
This PR is split into a couple of commits, so probably best reviewed separately. First commit moves the rejection reasons into the policy, second one adds the new rejection reasons for IRP. The store accessor makes this feel a little awkward so I'm open to any different approaches for doing this (could just keep all the rejection reasons in the
Decisionclass)