[LUPEYALPHA-760] EY scaffolding + landing page #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
12cc246 to
db39d8f
Compare
slorek
reviewed
Jul 24, 2024
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
d9d8256 to
5ea832f
Compare
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
aa717eb to
430bff0
Compare
AbigailMcP
commented
Jul 29, 2024
|
|
||
| <p class="govuk-body"> | ||
| You can find more information about employment contracts on the | ||
| <%= govuk_link_to("ACAS website", "#") %>. |
There was a problem hiding this comment.
@cwadsworthdfe - could you let me know where this should link to?
There was a problem hiding this comment.
Its this one:
https://www.acas.org.uk/employment-contracts
|
I've reviewed this and happy to approve.
Thanks! @AbigailMcP |
rjlynch
approved these changes
Jul 29, 2024
vacabor
approved these changes
Jul 29, 2024
asmega
reviewed
Jul 29, 2024
Comment on lines
8
to
9
| if Rails.env.production? | ||
| "https://www.example.com" # TODO: update to correct guidance |
There was a problem hiding this comment.
For FE i ended up removing this. from what I could tell, stakeholders wanted the landing page to be the start page
There was a problem hiding this comment.
ahh thank you! i think that's the same for EY - i'll remove too 👍
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
64ad60a to
724ad48
Compare
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
724ad48 to
6de10f7
Compare
- Add models (journey, eligibility, session, session_answers, slug_sequence, policy) for the new EarlyYearsPayment journey. - Add basic happy path spec that visits the landing page. - Add basic view for landing page - Include the new journey config in the seeds - Add migration to create early_years_payment_eligibilities.
Missing: - Links - Document downloads and styling - Contents list styling, TBC
Change the journey from EarlyYearsPayment to EarlyYearsPayment::Provider since there will be a second journey relating to the practitioner answers
AbigailMcP
force-pushed
the
LUPEYALPHA-760-ey-landing-page
branch
from
6de10f7 to
a8a4596
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes in this PR
the new
EarlyYearsPayment::Providerjourney.Out of scope
Guidance to review
How do we feel about the journey name
Journeys::EarlyYearsPayment::Provider?What about the journey name as it appears on the admin 'Manage service' page?
Prototype: https://claim-additi-main-9yrds6vyxcsd.herokuapp.com/landing-page
/early-years-payment-provider/landing-pageand compare against the prototype/admin/journey_configurations, turn the journey off