Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPT-1766 one login bypass #3023

Merged
merged 5 commits into from
Jul 30, 2024
Merged

CAPT-1766 one login bypass #3023

merged 5 commits into from
Jul 30, 2024

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Jul 22, 2024 •
edited
Loading

The env var BYPASS_ONELOGIN_SIGN_IN is set totrue,
which means the user will be logged in with email: [email protected] and name: TEST USER.
(note: the name from One Login currently comes back all capitalised).

This branch is built on top of the changes from #3001

@alkesh alkesh added the deploy Deploy a review app for this PR label Jul 22, 2024
@github-actions GitHub Actions
Copy link

Deployments

Journey URL
Additional Payments https://claim-additional-payments-for-teaching-review-3023-web.test.teacherservices.cloud/additional-payments/claim
Student Loans https://claim-additional-payments-for-teaching-review-3023-web.test.teacherservices.cloud/student-loans/claim
Further Education https://claim-additional-payments-for-teaching-review-3023-web.test.teacherservices.cloud/further-education-payments/landing-page
Relocation Payments https://claim-additional-payments-for-teaching-review-3023-web.test.teacherservices.cloud/get-a-teacher-relocation-payment/landing-page
Admin https://claim-additional-payments-for-teaching-review-3023-web.test.teacherservices.cloud/admin

@alkesh alkesh force-pushed the CAPT-1766-one-login-bypass branch from 008a758 to f20a492 Compare July 22, 2024 13:40
@alkesh alkesh force-pushed the CAPT-1766-one-login-bypass branch from ad555eb to c88d57a Compare July 23, 2024 10:29
@alkesh alkesh marked this pull request as ready for review July 23, 2024 10:29
@alkesh alkesh force-pushed the CAPT-1766-one-login-bypass branch from c88d57a to d28f455 Compare July 23, 2024 11:06
slorek
slorek reviewed Jul 24, 2024
View reviewed changes
Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is to be merged we will first need to move the sign in slug to the correct position in the sequence.

@alkesh alkesh force-pushed the CAPT-1766-one-login-bypass branch from 6ce277c to d66738a Compare July 30, 2024 08:39
rjlynch and others added 5 commits July 30, 2024 09:50
@rjlynch @alkesh
One Login proof of concept
dbd3528
@alkesh
move one login sign in to after eligibility checks
1dbaa92
@asmega @alkesh
add one login test and prod env vars
612f45e
@asmega @alkesh
disable one login in production
36a7811 
- this is tempory till one login productions have been added
- and integration has been completed
@asmega @alkesh
remove forced one login back links
0111604 
these are already populated by the controller
@alkesh alkesh force-pushed the CAPT-1766-one-login-bypass branch from d66738a to 0111604 Compare July 30, 2024 08:53
@alkesh alkesh merged commit 4666fee into master Jul 30, 2024
14 checks passed
@alkesh alkesh deleted the CAPT-1766-one-login-bypass branch July 30, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorek slorek slorek approved these changes

@asmega asmega asmega approved these changes

@kenfodder kenfodder kenfodder approved these changes

Assignees
No one assigned
Labels
deploy Deploy a review app for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alkesh @kenfodder @asmega @slorek @rjlynch