Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial IRP journey wire up #2880

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Initial IRP journey wire up #2880

merged 1 commit into from
Jun 20, 2024

Conversation

rjlynch
Copy link
Contributor

@rjlynch rjlynch commented Jun 19, 2024

This commit adds the initial set up for IRP along with a some feature
tests.
So far the IRP journey lets a user click "Start now" and then
shows the check your answers page where they can submit a claim.
The feature test has some temporary hacks, where we update the database
model, this is just required to get the answers in a state that passes
the validations on the claim. We'll be removing the
teacher_reference_number question and (probably) the payroll_gender
question from the IRP journey but they're currently required to submit a claim.

follow up PR that adds the first form to the journey

@rjlynch rjlynch force-pushed the integrate-irp branch 2 times, most recently from e538cfa to 06cecae Compare June 19, 2024 13:30
@rjlynch rjlynch requested a review from slorek June 19, 2024 13:57
Copy link
Contributor

@slorek slorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Perhaps we need a migration or rake task to create the journey configuration record as well.

@rjlynch
Copy link
Contributor Author

rjlynch commented Jun 20, 2024

Looks great. Perhaps we need a migration or rake task to create the journey configuration record as well.

👍 Have added a ticket to get that done
https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1733

@rjlynch rjlynch force-pushed the integrate-irp branch 2 times, most recently from 0451af4 to b86a3e2 Compare June 20, 2024 15:27
This commit adds the initial set up for IRP along with a some feature
test.
So far the IRP journey lets a user click "Start now" and then
shows the check your answers page where they can submit a claim.
The feature test has some temporary hacks, where we update the database
model, this is just required to get the answers in a state that passes
the validations on the claim. We'll be removing the
`teacher_reference_number` question and (probably) the `payroll_gender`
question from the IRP journey but they're currently required.
@rjlynch rjlynch merged commit 3dae68e into master Jun 20, 2024
13 of 15 checks passed
@rjlynch rjlynch deleted the integrate-irp branch June 20, 2024 15:34
@asmega asmega mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants