BUGFIX Show the correct name for the previous journey #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `current_journey_routing` name shows the name of the journey we're switching too. We need to take a look at the journey the user came from which will be the `first` journey session. Due to how we clear the session when the user starts a new journey there will only ever be two journey sessions in the `journey_sessions` collection. In this specific case on the existing session page, there is only one journey session in the journey_sessions collection (as the session for the journey we're considering switching too hasn't been created)
rjlynch
force-pushed
the
bug-fix-show-correct-for-previous-journey
branch
from
b69fcb4 to
d88be98
Compare
rjlynch
changed the title
asmega
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this one while checking switching journey to / from IRP
The
current_journey_routingname shows the name of the journey we'reswitching to. We need to take a look at the journey the user came from
which will be the
firstjourney session.Due to how we clear the session when the user starts a new journey there
will only ever be two journey sessions in the
journey_sessionscollection. In this specific case, on the existing session page, there is
only one journey session in the journey_sessions collection (as the
session for the journey we're considering switching too hasn't been
created, and as such
journey_sessionisnil)Looking at the git history I think this has been an issue for a while. As part
of the IRP work I'm adding some regression tests that will catch this but
didn't want to block this bug fix on that work.
If we do decide to support multiple inflight journeys this whole "existing
session" handling code can be removed and the claims controller can be
simplified quite a bit.
Before
After