Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method reset_dependent_answers #2873

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

felixclack
Copy link
Contributor

Now that we're storing answers on an object separate from a claim, we no
longer need to reset attributes on the claim itself.

The method that handles this is redundant and can be safely removed.

Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 current claim has been deleted on master so you can just remove that file and spec

Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also remove the ATTRIBUTE_DEPENDENCIES constants as I don't think they're referenced anymore

@felixclack felixclack force-pushed the reset-dependent-answers branch 4 times, most recently from 6b944cf to b412551 Compare June 19, 2024 08:42
Now that we're storing answers on an object separate from a claim, we no
longer need to reset attributes on the claim itself.

The method that handles this is redundant and can be safely removed.
@felixclack felixclack force-pushed the reset-dependent-answers branch from b412551 to 7ebf7ad Compare June 19, 2024 08:43
@felixclack felixclack merged commit bb07c2e into master Jun 19, 2024
15 checks passed
@felixclack felixclack deleted the reset-dependent-answers branch June 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants