Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DfE identity sign in page #2872

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fix DfE identity sign in page #2872

merged 3 commits into from
Jun 18, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jun 18, 2024 •
edited
Loading

Context

  • The DfE identity sign in page is not quite right

Changes

  • Use GOVUK component for back link
  • Removed duplicated nested <main> in sign in page
  • Use the back link in layout rather than in view to fix visual issues
  • Removed superfluous mark up on the page if there are no errors

Screenshots

Before

Screenshot 2024-06-18 at 09 33 43

After

Screenshot 2024-06-18 at 09 34 04

@asmega asmega changed the title Fix dfe sign in page Fix DfE identity sign in page Jun 18, 2024
@asmega asmega marked this pull request as ready for review June 18, 2024 08:36
@asmega asmega force-pushed the fix-dfe-sign-in-page branch from 3965f43 to 6f8d5d5 Compare June 18, 2024 09:33
@asmega asmega merged commit 765b6a2 into master Jun 18, 2024
15 checks passed
@asmega asmega deleted the fix-dfe-sign-in-page branch June 18, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slorek slorek slorek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @slorek