Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAPT-1729] Form tweaks to reminders journey #2858

Merged
merged 5 commits into from
Jun 18, 2024
Merged

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jun 17, 2024

Context

Changes

  • Remove GovukFormHelper#css_classes_for_select which was never used anywhere
  • Use GOVUKDesignSystemFormBuilder::FormBuilder for reminder journey forms
  • Swap out any custom code to use GOVUK formbuilder
  • Use GOVUK components where applicable
  • Bonus: one page had multiple h1s, this has now been fixed

@asmega asmega marked this pull request as ready for review June 17, 2024 09:46
@asmega asmega force-pushed the minor-form-tweaks branch from bdbc399 to 7dee121 Compare June 18, 2024 09:00
@asmega asmega force-pushed the minor-form-tweaks branch from 7dee121 to c8f76c3 Compare June 18, 2024 09:09
@asmega asmega merged commit 51ef8c7 into master Jun 18, 2024
15 checks passed
@asmega asmega deleted the minor-form-tweaks branch June 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants