Remove claim as a form argument #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
changed the title
rjlynch
changed the title
rjlynch
force-pushed
the
CAPT-1724/remomve-claim-from-form
branch
from
eccf943 to
e369617
Compare
asmega
approved these changes
Jun 14, 2024
Now the forms no longer reference the current claim we can remove it as an argument. Of note we've had to hack the reminders form a bit. The reminders controller passes in the reminder to the form as the claim argument. We've removed the "current_data_object" method as it's too much abstraction and added some methods to the reminder forms to still let them work with the claim, which is really a reminder. The reminders forms probably shouldn't share a base class with the usual forms but unpicking that is a future exercise. These hacks will hopefully be addressed in https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1719
The reminders forms work with a reminder not a claim, so we want to update the arguments to make this clear. The reminders forms likely shouldn't share the same base class as the answers forms but changing this is outside of the scope of this rather large pr!
rjlynch
force-pushed
the
CAPT-1724/remomve-claim-from-form
branch
from
e369617 to
8c9836b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the forms no longer reference the current claim we can remove it as
an argument.
Of note we've had to hack the reminders form a bit. The reminders
controller passes in the reminder to the form as the claim argument.
We've removed the "current_data_object" method as it's too much
abstraction and added some methods to the reminder forms to still let
them work with the claim, which is really a reminder. The reminders
forms probably shouldn't share a base class with the usual forms but
unpicking that is a future exercise. These hacks will hopefully be
addressed in https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1719
A lot of files changed but most of them are just specs that needed updating