Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning #2849

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix deprecation warning #2849

merged 2 commits into from
Jun 14, 2024

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Jun 14, 2024

Context

  • Fix deprecation warning in tests
  • Also removed someones personal note that don't belong

@asmega asmega marked this pull request as ready for review June 14, 2024 10:21
rjlynch
rjlynch approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmega asmega force-pushed the fix-deprecation branch from 28fe055 to 9ecea3e Compare June 14, 2024 11:11
@asmega asmega merged commit 892ca0e into master Jun 14, 2024
15 checks passed
@asmega asmega deleted the fix-deprecation branch June 14, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjlynch rjlynch rjlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @rjlynch