CAPT-1720/Remove shim #2845
Merged
CAPT-1720/Remove shim #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjlynch
changed the base branch from
master
to
CAPT-1718/dont-reference-claim-in-answers-presenter
rjlynch
force-pushed
the
CAPT-1718/dont-reference-claim-in-answers-presenter
branch
from
2ddcabe to
8c099b8
Compare
rjlynch
force-pushed
the
CAPT-1718/dont-reference-claim-in-answers-presenter
branch
from
8c099b8 to
9726400
Compare
rjlynch
commented
Jun 13, 2024
| @@ -47,6 +47,22 @@ def sent_one_time_password_at? | |||
| rescue Date::Error | |||
| false | |||
| end | |||
|
|
|||
| def load_current_value(attribute) | |||
There was a problem hiding this comment.
Have a ticket to sort this https://dfedigital.atlassian.net.mcas.ms/browse/CAPT-1719
rjlynch
force-pushed
the
CAPT-1718/dont-reference-claim-in-answers-presenter
branch
from
9726400 to
04c0356
Compare
rjlynch
force-pushed
the
CAPT-1718/dont-reference-claim-in-answers-presenter
branch
from
04c0356 to
3404d33
Compare
Base automatically changed from
CAPT-1718/dont-reference-claim-in-answers-presenter
to
master
June 13, 2024 16:45
Dont need to test claim any more
Now now form are writing to the journey session we can remove the shim classes
Removes the hacks we had to put into the journey session to check if it contained the answer to a question. We've left setting attributes from the claim on the reminders forms as they still write some otp data to the claim / do some weired stuff with writing data from the session to the form.
kenfodder
approved these changes
Jun 13, 2024
|
Nice one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shim
Now no forms are writing to the journey session we can remove the shim
classes