-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAPT-1632 Implement review apps #2737
Conversation
Review app deployed to https://s118d02-app-pr-2737-as.azurewebsites.net/additional-payments/claim |
3b03f08
to
52be482
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Looking very good, only a handful of issues remaining.
These are the things I've tested:
✅ Basic auth
✅ DfE Identity sign in
✅ Claim submission
✅ Exception reporting to Rollbar
✅ Ordnance survey API address lookup
✅ HMRC API integration
✅ e-mails sent
✅ Admin login with DfE Sign In
✅ Levelling Up Premium Payments awards upload
✅ TPS data upload
✅ School data import
✅ Checked application and deployment logs for errors
✅ Opening a PR against another PR already deployed keeps the deployment status and PR comments separate from the base branch PR
✅ Close PR deletes the review app
✅ Reopening a close PR re-deploys the review app
Remaining Issues:
🛑 We should upgrade from Postgres 11 to Postgres 16 which we will be doing for the production environment at the same time as well
🛑 DQT client is not working (I've checked the credentials are present and correct; seems to be a networking issue but works locally):
irb(main):002:0> c = Dqt::Client.new
irb(main):005:0> c.teacher.find("1886092")
/usr/local/lib/ruby/3.2.0/net/http.rb:1603:in `initialize': Failed to open TCP connection to preprod.teacher-qualifications-api.education.gov.uk:443 (getaddrinfo: Try again) (Faraday::ConnectionFailed)
…tal/claim-additional-payments-for-teaching into capt-1632-implement-review-apps
Changes made in this PR
-aks
suffixesdevelopment
config and replaced withtest
envbuild_and_deploy
workflow to deploy review app when 'deploy' label addedGuidance to review
Not included