Introduces journey session model #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://s118d02-app-pr-2734-as.azurewebsites.net/additional-payments/claim |
rjlynch
force-pushed
the
CAPT-1635/initial-journey-session-setup
branch
from
d472974 to
3e6461e
Compare
slorek
approved these changes
May 8, 2024
kenfodder
approved these changes
May 8, 2024
Yeah I've got a ticket for that 👍 |
rjlynch
force-pushed
the
CAPT-1635/initial-journey-session-setup
branch
from
3e6461e to
8c19425
Compare
your
approved these changes
May 8, 2024
felixclack
approved these changes
May 8, 2024
rjlynch
force-pushed
the
CAPT-1635/initial-journey-session-setup
branch
2 times, most recently
from
2d44766 to
ed9223a
Compare
As part of the efforts to simplify multi claim handling we want to move away from creating a claim at the start of the journey and instead only create the claim at the final step where the teacher submits their answers. This commit introduces a new model `Journeys::Session` which will be used to store the answers entered by the teacher. The answers will be stored in a json column on the new model, once validated by the form objects. `Journeys::Session` is currently the best name we could come up with but we're all ears for any better suggestions.
rjlynch
force-pushed
the
CAPT-1635/initial-journey-session-setup
branch
from
ed9223a to
c56fc38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the efforts to simplify multi claim handling we want to move
away from creating a claim at the start of the journey and instead only
create the claim at the final step where the teacher submits their
answers.
This commit introduces a new model
Journeys::Sessionwhich will beused to store the answers entered by the teacher. The answers will be
stored in a json column on the new model, once validated by the form
objects.
Journeys::Sessionis currently the best name we could come up with butwe're all ears for any better suggestions.