Merge pull request #3346 from DFE-Digital/make-verification-timestamp…

…s-available-in-reports

Set verified at on the claim

app/forms/journeys/further_education_payments/provider/verify_claim_form.rb

@@ -107,22 +107,28 @@ def assertions_attributes=(params)
         def save
           return false unless valid?
 
-          claim.eligibility.update!(
-            verification: {
-              assertions: assertions.map(&:attributes),
-              verifier: {
-                dfe_sign_in_uid: answers.dfe_sign_in_uid,
-                first_name: answers.dfe_sign_in_first_name,
-                last_name: answers.dfe_sign_in_last_name,
-                email: answers.dfe_sign_in_email,
-                dfe_sign_in_organisation_name: answers.dfe_sign_in_organisation_name,
-                dfe_sign_in_role_codes: answers.dfe_sign_in_role_codes
-              },
-              created_at: DateTime.now
-            }
-          )
-
-          claim.save!
+          ApplicationRecord.transaction do
+            verified_at = DateTime.now
+
+            claim.eligibility.update!(
+              verification: {
+                assertions: assertions.map(&:attributes),
+                verifier: {
+                  dfe_sign_in_uid: answers.dfe_sign_in_uid,
+                  first_name: answers.dfe_sign_in_first_name,
+                  last_name: answers.dfe_sign_in_last_name,
+                  email: answers.dfe_sign_in_email,
+                  dfe_sign_in_organisation_name: answers.dfe_sign_in_organisation_name,
+                  dfe_sign_in_role_codes: answers.dfe_sign_in_role_codes
+                },
+                created_at: verified_at
+              }
+            )
+
+            claim.verified_at = verified_at
+
+            claim.save!
+          end
 
           ClaimMailer
             .further_education_payment_provider_confirmation_email(claim)

app/models/claim.rb

@@ -92,7 +92,8 @@ class Claim < ApplicationRecord
     paye_reference: true,
     practitioner_email_address: true,
     provider_contact_name: true,
-    started_at: false
+    started_at: false,
+    verified_at: false
   }.freeze
   DECISION_DEADLINE = 12.weeks
   DECISION_DEADLINE_WARNING_POINT = 2.weeks

config/analytics.yml

@@ -79,6 +79,7 @@ shared:
     - onelogin_auth_at
     - onelogin_idv_at
     - started_at
+    - verified_at
   :decisions:
     - id
     - result

db/migrate/20241028095040_add_verified_at_timestamp_to_claims.rb

@@ -0,0 +1,5 @@
+class AddVerifiedAtTimestampToClaims < ActiveRecord::Migration[7.0]
+  def change
+    add_column :claims, :verified_at, :datetime
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2024_10_17_113701) do
+ActiveRecord::Schema[7.0].define(version: 2024_10_28_095040) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "citext"
   enable_extension "pg_trgm"
@@ -112,6 +112,7 @@
     t.text "onelogin_idv_last_name"
     t.date "onelogin_idv_date_of_birth"
     t.datetime "started_at", precision: nil, null: false
+    t.datetime "verified_at"
     t.index ["academic_year"], name: "index_claims_on_academic_year"
     t.index ["created_at"], name: "index_claims_on_created_at"
     t.index ["eligibility_type", "eligibility_id"], name: "index_claims_on_eligibility_type_and_eligibility_id"

spec/forms/journeys/further_education_payments/provider/verify_claim_form_spec.rb

@@ -344,6 +344,8 @@
           "created_at" => "2024-01-01T12:00:00.000+00:00"
         }
       )
+
+      expect(claim.verified_at).to eq(DateTime.new(2024, 1, 1, 12, 0, 0))
     end
 
     it "creates a provider verification task" do