change eligibility factory traits - new trait: not_verified

DFE-Digital · Sep 25, 2024 · d7e54d8 · d7e54d8
1 parent deb658b
commit d7e54d8
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/spec/factories/policies/further_education_payments/eligibilities.rb b/spec/factories/policies/further_education_payments/eligibilities.rb
@@ -6,13 +6,19 @@
     trait :eligible do
       eligible_school
       contract_type { "permanent" }
+      verified
+    end
+
+    trait :not_verified do
+      eligible_school
+      contract_type { "permanent" }
     end
 
     trait :eligible_school do
       association :school, factory: :fe_eligible_school
     end
 
-    trait :eligible_duplicate do
+    trait :duplicate do
       flagged_as_duplicate { true }
     end
 

diff --git a/spec/features/admin/admin_view_claim_further_education_payments_spec.rb b/spec/features/admin/admin_view_claim_further_education_payments_spec.rb
@@ -8,7 +8,7 @@
       :claim,
       :submitted,
       policy: Policies::FurtherEducationPayments,
-      eligibility_trait: :eligible
+      eligibility_trait: :not_verified
     )
   }
   let!(:claim_with_trn) {
@@ -24,15 +24,15 @@
       :claim,
       :submitted,
       policy: Policies::FurtherEducationPayments,
-      eligibility_trait: :eligible_duplicate
+      eligibility_trait: :duplicate
     )
   }
   let!(:claim_with_duplicates_provider_email_sent) {
     create(
       :claim,
       :submitted,
       policy: Policies::FurtherEducationPayments,
-      eligibility_trait: :eligible_duplicate
+      eligibility_trait: :duplicate
     )
   }
   let!(:verified_claim) {

diff --git a/spec/models/claim_spec.rb b/spec/models/claim_spec.rb
@@ -909,10 +909,10 @@
   describe ".awaiting_further_education_provider_verification" do
     subject { described_class.awaiting_further_education_provider_verification }
 
-    let!(:claim_not_verified_provider_email_automatically_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible) }
-    let!(:claim_not_verified_provider_email_not_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible_duplicate) }
-    let!(:claim_not_verified_has_duplicates_provider_email_not_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible_duplicate) }
-    let!(:claim_not_verified_has_duplicates_provider_email_manually_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible_duplicate) }
+    let!(:claim_not_verified_provider_email_automatically_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :not_verified) }
+    let!(:claim_not_verified_provider_email_not_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :duplicate) }
+    let!(:claim_not_verified_has_duplicates_provider_email_not_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :duplicate) }
+    let!(:claim_not_verified_has_duplicates_provider_email_manually_sent) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :duplicate) }
     let!(:claim_with_fe_provider_verification) { create(:claim, policy: Policies::FurtherEducationPayments, eligibility_trait: :verified) }
     let!(:non_fe_claim) { create(:claim, policy: Policies::StudentLoans) }
 
@@ -1344,13 +1344,13 @@
 
     context "when the eligiblity is not verified" do
       context "when there are no duplicates" do
-        let(:claim) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible) }
+        let(:claim) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :not_verified) }
 
         it { is_expected.to be true }
       end
 
       context "when there are duplicates" do
-        let(:claim) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :eligible_duplicate) }
+        let(:claim) { create(:claim, :submitted, policy: Policies::FurtherEducationPayments, eligibility_trait: :duplicate) }
 
         context "the provider email has not been sent" do
           it { is_expected.to be false }

diff --git a/spec/support/admin_view_claim_feature_shared_examples.rb b/spec/support/admin_view_claim_feature_shared_examples.rb
@@ -42,11 +42,7 @@
   }
 
   let!(:approved_awaiting_payroll_claim) {
-    eligibility = if policy == Policies::FurtherEducationPayments
-      create(:"#{policy.to_s.underscore}_eligibility", :verified)
-    else
-      create(:"#{policy.to_s.underscore}_eligibility", :eligible)
-    end
+    eligibility = create(:"#{policy.to_s.underscore}_eligibility", :eligible)
     create(
       :claim,
       :payrollable,