Rename key

Renames the `hours_teaching_eligible_subjects` key to `half_teaching_hours` as `half_teaching_hours` maps to the question shown to the claimant.
DFE-Digital · Aug 28, 2024 · c7fbafb · c7fbafb
1 parent eeac873
commit c7fbafb
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb b/app/forms/journeys/further_education_payments/provider/verify_claim_form.rb
@@ -10,7 +10,7 @@ class VerifyClaimForm < Form
             teaching_responsibilities
             further_education_teaching_start_year
             teaching_hours_per_week
-            hours_teaching_eligible_subjects
+            half_teaching_hours
             subjects_taught
           ],
           variable_contract: %i[
@@ -19,7 +19,7 @@ class VerifyClaimForm < Form
             further_education_teaching_start_year
             taught_at_least_one_term
             teaching_hours_per_week
-            hours_teaching_eligible_subjects
+            half_teaching_hours
             subjects_taught
             teaching_hours_per_week_next_term
           ]

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -1114,15 +1114,15 @@ en:
             teaching_responsibilities: "Is %{claimant} a member of staff with teaching responsibilities?"
             further_education_teaching_start_year: "Is %{claimant} in the first 5 years of their further education teaching career in England?"
             teaching_hours_per_week: "Is %{claimant} timetabled to teach an average of 12 hours per week during the current term?"
-            hours_teaching_eligible_subjects: "For at least half of their timetabled teaching hours, does %{claimant} teach 16- to 19-year-olds, including those up to age 25 with an Education, Health and Care Plan (EHCP)?"
+            half_teaching_hours: "For at least half of their timetabled teaching hours, does %{claimant} teach 16- to 19-year-olds, including those up to age 25 with an Education, Health and Care Plan (EHCP)?"
             subjects_taught: "For at least half of their timetabled teaching hours, does %{claimant} teach:"
           variable_contract:
             contract_type: "Does %{claimant} have a variable hour contract of employment at %{provider}?"
             teaching_responsibilities: "Is %{claimant} a member of staff with teaching responsibilities?"
             further_education_teaching_start_year: "Is %{claimant} in the first 5 years of their further education teaching career in England?"
             taught_at_least_one_term: "Has %{claimant} taught for at least one academic term at %{provider}?"
             teaching_hours_per_week: "Is %{claimant} timetabled to teach an average of 12 hours per week during the current term?"
-            hours_teaching_eligible_subjects: "For at least half of their timetabled teaching hours, does %{claimant} teach 16- to 19-year-olds, including those up to age 25 with an Education, Health and Care Plan (EHCP)?"
+            half_teaching_hours: "For at least half of their timetabled teaching hours, does %{claimant} teach 16- to 19-year-olds, including those up to age 25 with an Education, Health and Care Plan (EHCP)?"
             subjects_taught: "For at least half of their timetabled teaching hours, does %{claimant} teach:"
             teaching_hours_per_week_next_term: "Will %{claimant} be timetabled to teach at least 2.5 hours per week next term?"
 

diff --git a/spec/factories/policies/further_education_payments/eligibilities.rb b/spec/factories/policies/further_education_payments/eligibilities.rb
@@ -27,7 +27,7 @@
               "outcome" => true
             },
             {
-              "name" => "hours_teaching_eligible_subjects",
+              "name" => "half_teaching_hours",
               "outcome" => false
             },
             {

diff --git a/spec/forms/journeys/further_education_payments/provider/verify_claim_form_spec.rb b/spec/forms/journeys/further_education_payments/provider/verify_claim_form_spec.rb
@@ -78,7 +78,7 @@
             teaching_responsibilities
             further_education_teaching_start_year
             teaching_hours_per_week
-            hours_teaching_eligible_subjects
+            half_teaching_hours
             subjects_taught
           ]
         )
@@ -101,7 +101,7 @@
             further_education_teaching_start_year
             taught_at_least_one_term
             teaching_hours_per_week
-            hours_teaching_eligible_subjects
+            half_teaching_hours
             subjects_taught
             teaching_hours_per_week_next_term
           ]
@@ -121,7 +121,7 @@
               "1": {name: "teaching_responsibilities", outcome: "1"},
               "2": {name: "further_education_teaching_start_year", outcome: "1"},
               "3": {name: "teaching_hours_per_week", outcome: "1"},
-              "4": {name: "hours_teaching_eligible_subjects", outcome: "0"},
+              "4": {name: "half_teaching_hours", outcome: "0"},
               "5": {name: "subjects_taught", outcome: "0"}
             }
           }
@@ -154,7 +154,7 @@
               "outcome" => true
             },
             {
-              "name" => "hours_teaching_eligible_subjects",
+              "name" => "half_teaching_hours",
               "outcome" => false
             },
             {