Skip to content

Commit

Permalink
Merge pull request #3322 from DFE-Digital/static-error-pages
Browse files Browse the repository at this point in the history
[LUPEYALPHA-1168] Upgrade static error pages to govuk 5.7.1
  • Loading branch information
asmega authored Oct 16, 2024
2 parents 2d0e251 + e94851e commit bcac317
Show file tree
Hide file tree
Showing 19 changed files with 38 additions and 22 deletions.
12 changes: 6 additions & 6 deletions public/404.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

<meta http-equiv="X-UA-Compatible" content="IE=edge" />

<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/assets/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/assets/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/assets/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/assets/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/assets/images/govuk-icon-512.png" />
<link href="/govuk-frontend-5.3.1.min.css" rel="stylesheet" />
<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/images/govuk-icon-512.png" />
<link href="/govuk-frontend-5.7.1.min.css" rel="stylesheet" />
</head>

<body class="govuk-template__body">
Expand Down
12 changes: 6 additions & 6 deletions public/422.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@

<meta http-equiv="X-UA-Compatible" content="IE=edge" />

<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/assets/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/assets/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/assets/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/assets/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/assets/images/govuk-icon-512.png" />
<link href="/govuk-frontend-5.3.1.min.css" rel="stylesheet" />
<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/images/govuk-icon-512.png" />
<link href="/govuk-frontend-5.7.1.min.css" rel="stylesheet" />
</head>

<body class="govuk-template__body">
Expand Down
13 changes: 6 additions & 7 deletions public/500.html
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,12 @@

<meta http-equiv="X-UA-Compatible" content="IE=edge" />

<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/assets/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/assets/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/assets/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/assets/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/assets/images/govuk-icon-512.png" />
<link rel="apple-touch-icon" href="/assets/images/govuk-apple-touch-icon.png" />
<link href="/govuk-frontend-5.3.1.min.css" rel="stylesheet" />
<link rel="shortcut icon" sizes="16x16 32x32 48x48" href="/images/favicon.ico" type="image/x-icon" />
<link rel="mask-icon" href="/images/govuk-icon-mask.svg" color="#0b0c0c" />
<link rel="apple-touch-icon" sizes="180x180" href="/images/govuk-icon-180.png" />
<link rel="apple-touch-icon" sizes="192x192" href="/images/govuk-icon-192.png" />
<link rel="apple-touch-icon" sizes="512x512" href="/images/govuk-icon-512.png" />
<link href="/govuk-frontend-5.7.1.min.css" rel="stylesheet" />
</head>

<body class="govuk-template__body">
Expand Down
Binary file added public/favicon.ico
Binary file not shown.
Binary file added public/fonts/bold-affa96571d-v2.woff
Binary file not shown.
Binary file added public/fonts/bold-b542beb274-v2.woff2
Binary file not shown.
Binary file added public/fonts/light-94a07e06a1-v2.woff2
Binary file not shown.
Binary file added public/fonts/light-f591b13f7d-v2.woff
Binary file not shown.
3 changes: 0 additions & 3 deletions public/govuk-frontend-5.3.1.min.css

This file was deleted.

2 changes: 2 additions & 0 deletions public/govuk-frontend-5.7.1.min.css

Large diffs are not rendered by default.

Binary file added public/images/favicon.ico
Binary file not shown.
1 change: 1 addition & 0 deletions public/images/favicon.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions public/images/govuk-crest.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/images/govuk-icon-180.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/images/govuk-icon-192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/images/govuk-icon-512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions public/images/govuk-icon-mask.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/images/govuk-opengraph-image.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 15 additions & 0 deletions spec/features/static_error_pages_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
require "rails_helper"

RSpec.feature "static error pages", js: true do
scenario "404" do
expect { visit "/404" }.not_to raise_error
end

scenario "422" do
expect { visit "/422" }.not_to raise_error
end

scenario "500" do
expect { visit "/500" }.not_to raise_error
end
end

0 comments on commit bcac317

Please sign in to comment.