-
Notifications
You must be signed in to change notification settings - Fork 16
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Delegate to policy to decide auto pass logic and include failure
- Loading branch information
Showing
5 changed files
with
39 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,5 +36,9 @@ def verification_due_date_for_claim(claim) | |
def duplicate_claim?(claim) | ||
Claim::MatchingAttributeFinder.new(claim).matching_claims.exists? | ||
end | ||
|
||
def auto_pass_identity_confirmation_task(claim) | ||
claim.identity_confirmed_with_onelogin? ? :pass : :fail | ||
This comment has been minimized.
Sorry, something went wrong.
kenfodder
Author
Contributor
|
||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,8 @@ | |
This task was performed by <%= user_details(task.created_by, include_line_break: false) %> on <%= l(task.updated_at) %> | ||
<% elsif task.created_by %> | ||
This task was performed by an automated check uploaded by <%= user_details(task.created_by, include_line_break: false) %> on <%= l(task.created_at) %> | ||
<% elsif onelogin_auth_at = task.claim.onelogin_auth_at %> | ||
This task was performed by GOV.UK One Login on <%= l(onelogin_auth_at) %> | ||
<% elsif task.claim.identity_confirmed_with_onelogin? %> | ||
This task was performed by GOV.UK One Login on <%= l(task.claim.onelogin_idv_at) %> | ||
This comment has been minimized.
Sorry, something went wrong.
kenfodder
Author
Contributor
|
||
<% else %> | ||
This task was performed by an automated check on <%= l(task.created_at) %> | ||
<% end %> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the ability to fail the task here and not proceed to other matching, use
:skip
to allow it to continue with the DQT checks.