Skip to content

Commit

Permalink
Remove trainee_teacher from common_ineligible_attributes
Browse files Browse the repository at this point in the history
ECP `specific_ineligible_attributes?` already checks if
`trainee_teacher?` is set. For LUP trainee teachers can still be
eligible later, so we want to make sure we don't return ineligible in
that case.
This previously hasn't surfaced as an issue due to how the code was
called (a short circut specific to trainee teachers in the page
sequence) but we want to move some of the code around which exposes this
bug.
  • Loading branch information
rjlynch committed Dec 11, 2024
1 parent be35263 commit 6ec0f04
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion app/models/concerns/eligibility_checkable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ def trainee_teacher?
def common_ineligible_attributes?
[
indicated_ineligible_school?,
trainee_teacher?,
supply_teacher_lacking_either_long_contract_or_direct_employment?,
poor_performance?,
no_selectable_subjects?,
Expand Down

0 comments on commit 6ec0f04

Please sign in to comment.