Skip to content

Commit

Permalink
Fix hint text
Browse files Browse the repository at this point in the history
Previously the hint text was showing all subjects to claimants, even if
they were not eligible for those subjects, instead only show subjects
the claimant is eligible for. If the claimant is not eligible for any
subjects they will have been kicked out of the journey prior to this
screen.
  • Loading branch information
rjlynch committed Dec 3, 2024
1 parent 79ebfce commit 682d4e3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 4 additions & 1 deletion app/helpers/claims/itt_subject_helper.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
module Claims
module IttSubjectHelper
def subjects_to_sentence_for_hint_text(answers)
all_ecp_subjects = [:chemistry, :foreign_languages, :mathematics, :physics]
all_ecp_subjects = Policies::EarlyCareerPayments.subject_symbols(
claim_year: answers.policy_year,
itt_year: answers.itt_academic_year
)
all_lup_subjects = Policies::LevellingUpPremiumPayments.fixed_subject_symbols

hint_subject_symbols = Set[]
Expand Down
3 changes: 2 additions & 1 deletion spec/helpers/claims/itt_subject_helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@
build(
:additional_payments_answers,
:lup_ineligible,
:ecp_eligible_later
:ecp_eligible_later,
itt_academic_year: AcademicYear.new(2020)
)
end

Expand Down

0 comments on commit 682d4e3

Please sign in to comment.