Skip to content

Commit

Permalink
change admin hint copy for FE payroll gender
Browse files Browse the repository at this point in the history
  • Loading branch information
asmega committed Sep 11, 2024
1 parent 662acd0 commit 26562e2
Show file tree
Hide file tree
Showing 9 changed files with 50 additions and 31 deletions.
2 changes: 1 addition & 1 deletion app/views/admin/decisions/_incomplete_tasks.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<div class="govuk-error-summary__body">
<ul class="govuk-list govuk-error-summary__list claim-error-summary__list--warning">
<% incomplete_task_names.each do |name| %>
<li><%= link_to(t("admin.tasks.#{name}"), admin_claim_task_url(claim, name: name)) %></li>
<li><%= link_to(t("admin.tasks.#{name}.title"), admin_claim_task_url(claim, name: name)) %></li>
<% end %>
</ul>
</div>
Expand Down
4 changes: 2 additions & 2 deletions app/views/admin/tasks/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</div>
<div class="govuk-notification-banner__content">
<p class="govuk-notification-banner__heading">
<%= link_to "Multiple claims", admin_claim_task_path(claim_id: @claim.id, name: "matching_details") %>
<%= link_to "Multiple claims", admin_claim_task_path(claim_id: @claim.id, name: "matching_details") %>
with matching details have been made in this claim window.
</p>
</div>
Expand Down Expand Up @@ -39,7 +39,7 @@
<ul class="app-task-list__items">
<li class="app-task-list__item <%= task_name %>">
<span class="app-task-list__task-name">
<%= link_to I18n.t("admin.tasks.#{task_name}"), admin_claim_task_path(claim_id: @claim.id, name: task_name), class: "govuk-link" %>
<%= link_to I18n.t("admin.tasks.#{task_name}.title"), admin_claim_task_path(claim_id: @claim.id, name: task_name), class: "govuk-link" %>
</span>
<%= task_status_tag(@claim, task_name) %>
</li>
Expand Down
3 changes: 1 addition & 2 deletions app/views/admin/tasks/payroll_gender.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
<%= render "shared/error_summary", instance: @claim, errored_field_id_overrides: { "payroll_gender": "claim_payroll_gender_female" } if @claim.errors.any? %>

<div class="govuk-grid-row">

<%= render claim_summary_view, claim: @claim, heading: "Payroll gender" %>

<div class="govuk-grid-column-two-thirds">
Expand All @@ -24,7 +23,7 @@
</legend>

<p class="govuk-body">
The claimant answered ‘Don't know’ to the question ‘What gender does your school's payroll system associate with you?’
<%= t("#{Journeys.for_policy(@claim.policy)::I18N_NAMESPACE}.admin.tasks.payroll_gender.hint", default: [:"admin.tasks.payroll_gender.hint"]) %>
</p>

<%= hidden_field_tag "task[passed]", "true" %>
Expand Down
56 changes: 38 additions & 18 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,24 +133,41 @@ en:
unknown_payroll_gender_preventing_approval_message:
This claim cannot be approved, the payroll gender is missing and the claim will need to be referred
tasks:
qualifications: "Check qualification information"
induction_confirmation: "Check induction information"
employment: "Check employment information"
matching_details: "Review matching details from other claims"
identity_confirmation: "Confirm the claimant made the claim"
provider_verification: "Confirm the provider verification"
payroll_gender: "Add a payroll gender for HMRC"
student_loan_amount: "Check student loan amount"
student_loan_plan: "Check student loan plan"
payroll_details: "Check bank/building society account details"
census_subjects_taught: "Check eligible subjects are taught"
visa: "Check visa"
arrival_date: "Check arrival date"
employment_contract: "Check employment contract"
employment_start: "Check employment start date"
subject: "Check subject"
teaching_hours: "Check teaching hours"

qualifications:
title: "Check qualification information"
induction_confirmation:
title: "Check induction information"
employment:
title: "Check employment information"
matching_details:
title: "Review matching details from other claims"
identity_confirmation:
title: "Confirm the claimant made the claim"
provider_verification:
title: "Confirm the provider verification"
payroll_gender:
title: "Add a payroll gender for HMRC"
hint: "The claimant answered ‘Don't know’ to the question ‘What gender does your school's payroll system associate with you?’"
student_loan_amount:
title: "Check student loan amount"
student_loan_plan:
title: "Check student loan plan"
payroll_details:
title: "Check bank/building society account details"
census_subjects_taught:
title: "Check eligible subjects are taught"
visa:
title: "Check visa"
arrival_date:
title: "Check arrival date"
employment_contract:
title: "Check employment contract"
employment_start:
title: "Check employment start date"
subject:
title: "Check subject"
teaching_hours:
title: "Check teaching hours"
undo_decision:
approved: "Undo approval"
rejected: "Undo rejection"
Expand Down Expand Up @@ -847,6 +864,9 @@ en:
duplicate_claim: "Duplicate claim"
no_response: "No response"
other: "Other"
tasks:
payroll_gender:
hint: "The claimant answered ‘Don't know’ to the question ‘How is your gender recorded on your employer’s payroll system?'"
task_questions:
matching_details:
title: Is this claim still valid despite having matching details with other claims?
Expand Down
4 changes: 2 additions & 2 deletions spec/features/admin/admin_claim_payroll_details_task_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
find("a[href='#{admin_claim_tasks_path(claim)}']").click

expect(page).to have_content("Payroll details")
expect(page).to have_content I18n.t("admin.tasks.payroll_details")
expect(page).to have_content I18n.t("admin.tasks.payroll_details.title")

expect(page.find(".app-task-list__item.payroll_details")).to have_text("Incomplete")

click_on I18n.t("admin.tasks.payroll_details")
click_on I18n.t("admin.tasks.payroll_details.title")

expect(page).to have_content I18n.t("student_loans.admin.task_questions.payroll_details.title", bank_or_building_society: I18n.t("admin.#{claim.bank_or_building_society}"))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
expect(page).to have_content("6. Matching details")
expect(page).to have_content("7. Decision")

click_on I18n.t("admin.tasks.matching_details")
click_on I18n.t("admin.tasks.matching_details.title")

expect(page).to have_content(I18n.t("student_loans.admin.task_questions.matching_details.title"))
expect(page).to have_content(claim_with_matching_details.reference)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
expect(page).to have_content("6. Payroll gender")
expect(page).to have_content("7. Decision")

click_on I18n.t("admin.tasks.payroll_gender")
click_on I18n.t("admin.tasks.payroll_gender.title")

expect(page).to have_content("What gender should be passed to payroll and HMRC?")

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

expect(page).to have_content("1. Identity confirmation")

click_on I18n.t("admin.tasks.identity_confirmation")
click_on I18n.t("admin.tasks.identity_confirmation.title")

expect(page).to have_content("Did #{unverified_claim.full_name} submit the claim?")
expect(page).to have_content(unverified_claim.eligibility.current_school.name)
Expand Down
6 changes: 3 additions & 3 deletions spec/support/admin_checks_feature_shared_examples.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def lup_claim_checking_steps
visit admin_claims_path
find("a[href='#{admin_claim_tasks_path(claim)}']").click

click_on I18n.t("admin.tasks.identity_confirmation")
click_on I18n.t("admin.tasks.identity_confirmation.title")

expect(page).to have_content("Did #{claim.full_name} submit the claim?")
expect(page).to have_link("Next: Qualifications")
Expand Down Expand Up @@ -93,7 +93,7 @@ def ecp_claim_checking_steps
visit admin_claims_path
find("a[href='#{admin_claim_tasks_path(claim)}']").click

click_on I18n.t("admin.tasks.identity_confirmation")
click_on I18n.t("admin.tasks.identity_confirmation.title")

expect(page).to have_content("Did #{claim.full_name} submit the claim?")
expect(page).to have_link("Next: Qualifications")
Expand Down Expand Up @@ -176,7 +176,7 @@ def tslr_claim_checking_steps
visit admin_claims_path
find("a[href='#{admin_claim_tasks_path(claim)}']").click

click_on I18n.t("admin.tasks.identity_confirmation")
click_on I18n.t("admin.tasks.identity_confirmation.title")

expect(page).to have_content("Did #{claim.full_name} submit the claim?")
expect(page).to have_link("Next: Qualifications")
Expand Down

0 comments on commit 26562e2

Please sign in to comment.