Terraform to create Function App for Search #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killij
reviewed
Jan 5, 2024
| type = map(number) | ||
| default = { | ||
| Dev = 1 | ||
| Test = 1 |
There was a problem hiding this comment.
Not sure we need 2 in prod/pre-prod.
|
|
🎉 This PR is included in version 2.0.0-next.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added function app, storage account and required service plan.
It doesn't look like you can configure the source of the function app through Terraform. Azure supports linking this automatically to GitHub, but the portal wants to create a service principal that we do not have access to. We should look into what is possible with the Azure CLI similarly to how we deploy the main app image.