Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MediaElement Js plugin for Video and Audio controls #292

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

nnagepat
Copy link
Contributor

@nnagepat nnagepat commented Oct 3, 2023

No description provided.

@nnagepat nnagepat requested a review from killij October 3, 2023 14:12
Copy link
Contributor

@killij killij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to unbundle CSS and only include scripts on pages that need it.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

99.8% 99.8% Coverage
0.8% 0.8% Duplication

@nnagepat nnagepat merged commit 80989ce into main Oct 4, 2023
7 checks passed
@rgparkins
Copy link
Contributor

🎉 This PR is included in version 1.21.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@nnagepat nnagepat deleted the Feature/AudioResource branch October 12, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants