Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Resource search page #286

Merged
merged 18 commits into from
Sep 28, 2023
Merged

feat: Add Resource search page #286

merged 18 commits into from
Sep 28, 2023

Conversation

killij
Copy link
Contributor

@killij killij commented Sep 27, 2023

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.9% 0.9% Duplication

@@ -20,6 +20,7 @@
</ItemGroup>
<ItemGroup>
<Folder Include="Properties\" />
<Folder Include="wwwroot\assets\images\moj\" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these be removed when we have the final branding assets?

Copy link
Contributor Author

@killij killij Sep 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. Our use of the filter component from the MOJ package isn't final so they might get removed. Otherwise they're all there in support of the MOJ CSS.

Copy link
Contributor

@rgparkins rgparkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be good for Milesh to get some context as well on this as you are heading away

@killij killij merged commit 3567c65 into main Sep 28, 2023
@killij killij deleted the feat/resources branch September 28, 2023 10:10
@killij
Copy link
Contributor Author

killij commented Sep 28, 2023

🎉 This PR is included in version 1.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants