feat: Upgrade govuk package to 5.2.0 (#455)

Fixed breaking changes from v5
DFE-Digital · Mar 19, 2024 · 5bfe892 · 5bfe892
1 parent 54e3854
commit 5bfe892
Show file tree

Hide file tree

Showing 27 changed files with 1,691 additions and 1,814 deletions.
diff --git a/Childrens-Social-Care-CPD/Childrens-Social-Care-CPD.csproj b/Childrens-Social-Care-CPD/Childrens-Social-Care-CPD.csproj
@@ -29,6 +29,11 @@
     <Folder Include="Properties\" />
     <Folder Include="wwwroot\assets\images\moj\" />
   </ItemGroup>
+  <ItemGroup>
+    <Content Remove="wwwroot\javascript\govuk-frontend.min.js" />
+    <Content Remove="wwwroot\javascript\govuk-frontend.min.js.map" />
+    <Content Remove="wwwroot\assets\images\govuk-opengraph-image.png" />
+  </ItemGroup>
   <ItemGroup>
     <Content Update="Views\Shared\_Footer.cshtml">
       <ExcludeFromSingleFile>true</ExcludeFromSingleFile>

diff --git a/Childrens-Social-Care-CPD/Properties/launchSettings.json b/Childrens-Social-Care-CPD/Properties/launchSettings.json
@@ -11,10 +11,10 @@
     "Childrens_Social_Care_CPD": {
       "commandName": "Project",
       "launchBrowser": true,
+      "applicationUrl": "https://localhost:7112;http://localhost:5112",
       "environmentVariables": {
         "ASPNETCORE_ENVIRONMENT": "Development"
       },
-      "applicationUrl": "https://localhost:7112;http://localhost:5112",
       "dotnetRunMessages": true
     },
     "IIS Express": {
@@ -28,6 +28,7 @@
       "commandName": "Docker",
       "launchBrowser": true,
       "launchUrl": "{Scheme}://{ServiceHost}:{ServicePort}",
+      "environmentVariables": {},
       "publishAllPorts": true,
       "useSSL": true
     }

diff --git a/Childrens-Social-Care-CPD/Views/Shared/_SiteLayout.cshtml b/Childrens-Social-Care-CPD/Views/Shared/_SiteLayout.cshtml
@@ -13,7 +13,7 @@
     @await RenderSectionAsync("Head", required: false)
     @Html.RenderScripts(ScriptPosition.HeadEnd)
 
-    <link rel="shortcut icon" sizes="16x16 32x32 48x48" href="~/assets/images/favicon.ico" type="image/x-icon">
+    <link rel="shortcut icon" href="~/assets/images/favicon.ico" type="image/x-icon">
 
 </head>
 <body class="govuk-template__body">
@@ -32,13 +32,14 @@
     <partial name="_Footer" />
     <script src="~/lib/jquery/dist/jquery.min.js"></script>
     <script>
-        document.body.className = ((document.body.className) ? document.body.className + ' js-enabled' : 'js-enabled');
+        document.body.className += ' js-enabled' + ('noModule' in HTMLScriptElement.prototype ? ' govuk-frontend-supported' : '');
     </script>
     <!-- component HTML -->
-    <script src="/javascript/govuk-frontend-4.7.0.min.js"></script>
+    <script src="/javascript/govuk-frontend.min.js" type="module"></script>
     <script src="/javascript/dfefrontend-1.0.1.min.js"></script>
-    <script>
-        window.GOVUKFrontend.initAll()
+    <script type="module">
+        import { initAll } from '/javascript/govuk-frontend.min.js'
+        initAll()
     </script>
     @await RenderSectionAsync("Scripts", required: false)
     @Html.RenderScripts(ScriptPosition.BodyEnd)

diff --git a/Childrens-Social-Care-CPD/package-lock.json b/Childrens-Social-Care-CPD/package-lock.json
diff --git a/Childrens-Social-Care-CPD/package.json b/Childrens-Social-Care-CPD/package.json
@@ -15,7 +15,7 @@
   "dependencies": {
     "@ministryofjustice/frontend": "^1.8.0",
     "dfe-frontend-alpha": "^1.0.1",
-    "govuk-frontend": "^4.7.0",
+    "govuk-frontend": "^5.2.0",
     "jquery": "^3.7.0"
   }
 }
diff --git a/Childrens-Social-Care-CPD/styles/scss/application.scss b/Childrens-Social-Care-CPD/styles/scss/application.scss
@@ -3,7 +3,7 @@ $govuk-global-styles: true;
 $govuk-new-link-styles: true;
 $moj-images-path: "/assets/images/moj/";
 
-@import "../../node_modules/govuk-frontend/govuk/all";
+@import "../../node_modules/govuk-frontend/dist/govuk/all";
 @import "../../node_modules/@ministryofjustice/frontend/moj/components/filter/filter";
 @import '../../node_modules/dfe-frontend-alpha/packages/dfefrontend';
 @import "overrides/dfe-overrides";

diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/.DS_Store b/Childrens-Social-Care-CPD/wwwroot/assets/.DS_Store
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/.DS_Store b/Childrens-Social-Care-CPD/wwwroot/assets/images/.DS_Store
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/favicon.ico b/Childrens-Social-Care-CPD/wwwroot/assets/images/favicon.ico
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/favicon.svg b/Childrens-Social-Care-CPD/wwwroot/assets/images/favicon.svg
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-152x152.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-152x152.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-167x167.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-167x167.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-180x180.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon-180x180.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-apple-touch-icon.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-180.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-180.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-192.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-192.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-512.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-512.png
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-mask.svg b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-icon-mask.svg
diff --git a/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-opengraph-image.png b/Childrens-Social-Care-CPD/wwwroot/assets/images/govuk-opengraph-image.png