Tidy up old Resource search code

Childrens-Social-Care-CPD-Tests/Controllers/ResourcesControllerTests.cs

@@ -163,6 +163,42 @@ public async Task Index_Passes_Correctly_Tagged_Properties()
         properties["From"].Should().Be("Virtual Hubs");
     }
 
+    [TestCase("Topic", "Topic Text")]
+    [TestCase("From", "From Text")]
+    [TestCase("Estimated reading time", "15 mins")]
+    public async Task Index_Passes_Properties(string key, string value)
+    {
+        // arrange
+        var createdAt = DateTime.UtcNow.AddMinutes(-10);
+        var updatedAt = DateTime.UtcNow;
+        var content = new Content
+        {
+            EstimatedReadingTime = 15,
+            Sys = new()
+            {
+                CreatedAt = createdAt,
+                UpdatedAt = updatedAt,
+            }
+        };
+        var tags = CreateTagsResponse(new()
+        { 
+            new() { Id = "topicTopicText", Name = "Topic: Topic Text" },
+            new() { Id = "resourceProviderFromText", Name = "Resource provider: From Text" },
+            new() { Id = "estimatedReadingTime15", Name = "Estimated reading time: 15 mins" },
+        });
+
+        _resourcesRepository.GetByIdAsync(Arg.Any<string>(), cancellationToken: Arg.Any<CancellationToken>())
+            .Returns(Task.FromResult(Tuple.Create(content, tags)));
+
+        // act
+        var result = await _resourcesController.Index("foo") as ViewResult;
+        var properties = result.ViewData["Properties"] as IDictionary<string, string>;
+
+        // assert
+        properties.Should().NotBeNull();
+        properties[key].Should().Be(value);
+    }
+
     [Test]
     public async Task Index_Ignores_Unrelated_Tags_For_Properties()
     {
@@ -177,7 +213,7 @@ public async Task Index_Ignores_Unrelated_Tags_For_Properties()
                 UpdatedAt = updatedAt,
             }
         };
-        var tags = CreateTagsResponse(new() { new() { Id = "foo", Name = "Topic:Foo=foo" }, });
+        var tags = CreateTagsResponse(new() { new() { Id = "foo", Name = "Foo: Some value" }, });
 
         _resourcesRepository.GetByIdAsync(Arg.Any<string>(), cancellationToken: Arg.Any<CancellationToken>())
             .Returns(Task.FromResult(Tuple.Create(content, tags)));

Childrens-Social-Care-CPD/DataAccess/ResourcesRepository.cs

@@ -1,7 +1,6 @@
 using Childrens_Social_Care_CPD.Configuration;
 using Childrens_Social_Care_CPD.Contentful;
 using Childrens_Social_Care_CPD.Contentful.Models;
-using Childrens_Social_Care_CPD.Controllers;
 using Childrens_Social_Care_CPD.Search;
 using Childrens_Social_Care_CPD.GraphQL.Queries;
 using Contentful.Core.Search;

Childrens-Social-Care-CPD/Models/ResourceSearchResultsViewModel.cs

@@ -1,9 +1,11 @@
 using Azure.Search.Documents.Models;
 using Childrens_Social_Care_CPD.Contentful.Models;
 using Childrens_Social_Care_CPD.Search;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Childrens_Social_Care_CPD.Models;
 
+[ExcludeFromCodeCoverage]
 public record ResourceSearchResultsViewModel(
     Content PageContent,
     string SearchTerm,

Childrens-Social-Care-CPD/Models/SearchRequestModel.cs

@@ -1,4 +1,5 @@
 using Microsoft.AspNetCore.Mvc;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Childrens_Social_Care_CPD.Models;
 
@@ -17,6 +18,7 @@ public static class SearchRequestPropertyNames
     public const string SortOrder = "so";
 }
 
+[ExcludeFromCodeCoverage]
 public record SearchRequestModel
 {
     [BindProperty(Name = SearchRequestPropertyNames.Term, SupportsGet = true)]

Childrens-Social-Care-CPD/Models/SearchResultViewModel.cs

@@ -1,6 +1,8 @@
 using Azure.Search.Documents.Models;
 using Childrens_Social_Care_CPD.Search;
+using System.Diagnostics.CodeAnalysis;
 
 namespace Childrens_Social_Care_CPD.Models;
 
+[ExcludeFromCodeCoverage]
 public record SearchResultViewModel(SearchResult<CpdDocument> SearchResult, IReadOnlyDictionary<string, TagInfo> TagMap);