Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gcp wif in test env #425

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Enable gcp wif in test env #425

merged 2 commits into from
Nov 26, 2024

Conversation

RMcVelia
Copy link
Contributor

@RMcVelia RMcVelia commented Nov 26, 2024

Context

Enable GCP WIF for the test environment

Changes proposed in this pull request

Add required config
Also add gcp auth to delete review app workflow

Guidance to review

make test terraform-plan
and for delete review wf, see https://github.com/DFE-Digital/check-childrens-barred-list/actions/runs/12032062584

Link to Trello card

https://trello.com/c/zBJkGucG/2142-ccbl-migrate-to-gcp-wif

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@RMcVelia RMcVelia added the deploy Deploys a review app label Nov 26, 2024
@github-actions github-actions bot temporarily deployed to review-425 November 26, 2024 11:50 Destroyed
@RMcVelia RMcVelia closed this Nov 26, 2024
@RMcVelia RMcVelia reopened this Nov 26, 2024
@github-actions github-actions bot temporarily deployed to review-425 November 26, 2024 13:42 Destroyed
@RMcVelia RMcVelia force-pushed the 2142-ccbl-migrate-to-gcp-wif-2 branch from 40f1545 to bc342a9 Compare November 26, 2024 13:45
@github-actions github-actions bot temporarily deployed to review-425 November 26, 2024 13:47 Destroyed
@RMcVelia RMcVelia closed this Nov 26, 2024
@RMcVelia RMcVelia reopened this Nov 26, 2024
@RMcVelia
Copy link
Contributor Author

CCBL: migrate to GCP WIF

@github-actions github-actions bot temporarily deployed to review-425 November 26, 2024 13:58 Destroyed
@github-actions github-actions bot temporarily deployed to review-425 November 26, 2024 14:01 Destroyed
Copy link

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RMcVelia RMcVelia merged commit 1beff34 into main Nov 26, 2024
27 checks passed
@RMcVelia RMcVelia deleted the 2142-ccbl-migrate-to-gcp-wif-2 branch November 26, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Deploys a review app devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants