Create quarterly return logs #1603
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertparkinson
changed the title
Cruikshanks
requested changes
Jan 9, 2025
app/services/jobs/return-logs/create-quarterly-return-cycles.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/create-quarterly-return-cycles.service.js
Outdated
Show resolved
Hide resolved
app/services/jobs/return-logs/create-quarterly-return-cycles.service.js
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4841
As part of our work to replace NALD for the generation of return logs we're looking at introducing the concept of a quarterly return. This is an all year cycle that has been split into 4 3 month periods that water companies will return against through out the year.
This PR checks if the return version has been marked for quarterly returns, if it starts after the go live date and then creates the smaller return logs.
There is also some refactoring of the quarter period naming.