Skip to content

Commit

Permalink
Rename underlying view return version modules
Browse files Browse the repository at this point in the history
  • Loading branch information
Cruikshanks committed Oct 21, 2024
1 parent ce5443d commit 88f8f0a
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions app/controllers/return-versions.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
* @module ReturnVersionsController
*/

const ViewService = require('../services/return-requirements/view.service.js')
const ViewService = require('../services/return-versions/view.service.js')

async function view (request, h) {
const { id } = request.params
const pageData = await ViewService.go(id)

return h.view('return-requirements/view.njk', {
return h.view('return-versions/view.njk', {
...pageData
})
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
'use strict'

/**
* Orchestrates fetching and presenting the data for `/return-requirements/{sessionId}/view` page
* Orchestrates fetching and presenting the data for `/return-versions/{sessionId}/view` page
* @module ViewService
*/

const FetchReturnVersionService = require('./fetch-return-version.service.js')
const ViewPresenter = require('../../presenters/return-requirements/view.presenter.js')
const ViewPresenter = require('../../presenters/return-versions/view.presenter.js')

/**
* Orchestrates fetching and presenting the data for `/return-requirements/{sessionId}/view` page
* Orchestrates fetching and presenting the data for `/return-versions/{sessionId}/view` page
*
* @param {string} returnVersionId - The UUID for return requirement version
* @param {string} returnVersionId - The UUID for the return version
*
* @returns {Promise<object>} page data needed by the view template
*/
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion test/controllers/return-versions.controller.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const { describe, it, beforeEach, afterEach } = exports.lab = Lab.script()
const { expect } = Code

// Things we need to stub
const ViewService = require('../../app/services/return-requirements/view.service.js')
const ViewService = require('../../app/services/return-versions/view.service.js')

// For running our service
const { init } = require('../../app/server.js')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ const PointModel = require('../../../app/models/point.model.js')
const ReturnVersionModel = require('../../../app/models/return-version.model.js')

// Thing under test
const ViewPresenter = require('../../../app/presenters/return-requirements/view.presenter.js')
const ViewPresenter = require('../../../app/presenters/return-versions/view.presenter.js')

describe('Return Requirements - View presenter', () => {
describe('Return Versions - View presenter', () => {
let returnVersion

beforeEach(() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ const RequirementsForReturnsSeeder = require('../../support/seeders/requirements
const ModLogHelper = require('../../support/helpers/mod-log.helper.js')

// Thing under test
const FetchReturnVersionService = require('../../../app/services/return-requirements/fetch-return-version.service.js')
const FetchReturnVersionService = require('../../../app/services/return-versions/fetch-return-version.service.js')

describe('Return Requirements - Fetch Return Version service', () => {
describe('Return Versions - Fetch Return Version service', () => {
let licence
let modLog
let returnVersion
Expand All @@ -30,7 +30,7 @@ describe('Return Requirements - Fetch Return Version service', () => {
user = seedData.user
})

it('returns the details of the requirements for returns', async () => {
it('returns the details of the return version', async () => {
const result = await FetchReturnVersionService.go(returnVersion.id)

const [returnRequirementsOne, returnRequirementsTwo] = result.returnRequirements
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ const LicenceModel = require('../../../app/models/licence.model.js')
const ReturnVersionModel = require('../../../app/models/return-version.model.js')

// Things we want to stub
const FetchReturnVersionService = require('../../../app/services/return-requirements/fetch-return-version.service.js')
const FetchReturnVersionService = require('../../../app/services/return-versions/fetch-return-version.service.js')

// Thing under test
const ViewService = require('../../../app/services/return-requirements/view.service.js')
const ViewService = require('../../../app/services/return-versions/view.service.js')

describe('Return Requirements - View service', () => {
describe('Return Versions - View service', () => {
const returnVersionId = '0c6ed18f-39fb-4d70-93bb-cf24453dbb70'

beforeEach(async () => {
Expand Down

0 comments on commit 88f8f0a

Please sign in to comment.