Split charging data job; rtns, mod logs and other #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4654 > Part of the work to migrate management of return requirements from NALD to WRLS For reasons detailed in [Add return requirements clean up step to import](#1017) we need to add a new step into the existing 'charging-data' job. But the job itself is already a bit of a mish-mash. - it is called 'charging-data' but doesn't do that any more - it brings in fixed reference data, return versions and mod logs all in one go We know this will soon be ditched, but it is a right old mess as it is. We could be stopping some of the stuff right now, and split out the rest to make it a lot clearer as to what bit is doing what. This wouldn't be much more effort than trying to slot a new step into the existing mess. So, this change we perform some much needed tidying up of the 'charging-data job'. This should make the change in PR #1017 much easier!
Cruikshanks
added
the
housekeeping
We ensure we have an endpoint that allows us to trigger the job still, whilst dropping some of the noise and mess that previous job unnecessarily had.
What remains in the charging data job is just populating fixed reference data. There is no need to do this as this information never changes. We leave the job just in case we need to trigger it. But we stop updating these tables on a nightly basis for no reason.
Use what we default them to in the examples. Also reorder them in time order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4654
For reasons detailed in Add return requirements clean up step to import, we need to add a new step to the existing 'charging-data' job. But the job itself is already a bit of a mess.
We know this will soon be ditched, but it is a right-old mess. We could stop some of the stuff right now and split out the rest to make it much clearer which bit is doing what. This wouldn't be much more effort than slotting a new step into the mess.
So, in this change, we perform some much-needed tidying up of the 'charging-data job'. This should make the change in PR #1017 much easier!