-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move continue button to below the pricing summary #2101
base: develop
Are you sure you want to change the base?
Conversation
https://eaflood.atlassian.net/browse/IWTF-4379 https://eaflood.atlassian.net/browse/IWTF-4380 Pricing summary appears beneath green button. This means that if a user doesn't scroll down, they will miss them and may not know the licence price to make an informed decisions until further into the journey. This may result in a user clicking back and forth through the journey rather than proceeding smoothly through.
Quality Gate passedIssues Measures |
#continue { | ||
position: absolute; | ||
top: auto; | ||
bottom: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for px
here
.govuk-grid-row { | ||
position: relative; | ||
padding-bottom: 75px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These styles are fine, but they'll require far more testing effort than if you confined them to only the pages they're needed on - i.e. the licence type and licence length pages. To do this we can use the :has pseudo-class:
.govuk-grid-row:has(.payment-summary-wrap)
This will only target the #continue
and .govuk-grid-row
elements on pages where the payment summary exists, which is exactly what we want. The :has pseudo class is supported by mobile browsers released in 2022 and 2023, so well within Grade B support. Realistically, there will be those with old smartphones stuck on old versions of Android or iOS that don't offer support to this selector, but they'll regress gracefully to the version where the prices display beneath the continue button. We should check this with the PO after QA to see whether it's acceptable to do this.
https://eaflood.atlassian.net/browse/IWTF-4379
https://eaflood.atlassian.net/browse/IWTF-4380
Pricing summary appears beneath green button.
This means that if a user doesn't scroll down, they will miss them and may not know the licence price to make an informed decisions until further into the journey. This may result in a user clicking back and forth through the journey rather than proceeding smoothly through.