Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile phone links #2090

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Mobile phone links #2090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14f0243
Mobile phone links
Dec 6, 2024
bdb1c94
meta tags and add tests
Dec 10, 2024
f6dcd83
undo changes package.json
Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/gafl-webapp-service/src/pages/contact/contact/contact.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,9 @@
</div>
<div id="text-ro" class="govuk-body-m initially-hidden">
{{ mssgs.important_info_contact_input_mobile_note }}</br>
<span class="govuk-body-m govuk-!-font-weight-bold">{{ data.licensee.mobilePhone }}
<meta name="format-detection" content="telephone=no">
<span class="govuk-body-m govuk-!-font-weight-bold">{{ data.licensee.mobilePhone }}
</meta>
</span>
</div>
{% endset -%}
Expand Down
16 changes: 13 additions & 3 deletions ...c/pages/contact/digital-licence/check-confirmation-contact/check-confirmation-contact.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,19 @@
{{ title }}
</h1>

<p class="govuk-body contact-scroll" id="contact-information" aria-labelledby="contact-information">
{{ contactInfo }}
</p>

{% if data.licensee.preferredMethodOfConfirmation == 'Email' %}
<p class="govuk-body contact-scroll" id="contact-information" aria-labelledby="contact-information">
{{ contactInfo }}
</p>
{% else %}
<meta name="format-detection" content="telephone=no">
<p class="govuk-body contact-scroll" id="contact-information" aria-labelledby="contact-information">
{{ contactInfo }}
</p>
</meta>
{% endif %}


<p class="govuk-body govuk-!-margin-bottom-6">
<a class="govuk-link" href="{{ data.uri.change }}">
Expand Down
54 changes: 36 additions & 18 deletions ...bapp-service/src/pages/summary/contact-summary/__tests__/__snapshots__/route.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -934,7 +935,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1039,7 +1041,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1124,7 +1127,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1649,7 +1653,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1754,7 +1759,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1839,7 +1845,8 @@ Array [
"text": Symbol(contact-summary-row-licence-conf),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand Down Expand Up @@ -1924,7 +1931,8 @@ Array [
"text": Symbol(contact-summary-row-licence),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2029,7 +2037,8 @@ Array [
"text": Symbol(contact-summary-row-licence-conf),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2114,7 +2123,8 @@ Array [
"text": Symbol(contact-summary-row-licence),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2219,7 +2229,8 @@ Array [
"text": Symbol(contact-summary-row-licence-conf),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand All @@ -2239,7 +2250,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2304,7 +2316,8 @@ Array [
"text": Symbol(contact-summary-row-licence),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand All @@ -2324,7 +2337,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2409,7 +2423,8 @@ Array [
"text": Symbol(contact-summary-row-licence-conf),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand All @@ -2429,7 +2444,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down Expand Up @@ -2494,7 +2510,8 @@ Array [
"text": Symbol(contact-summary-row-licence),
},
"value": Object {
"text": "contact-summary-text-sngl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text message-contact-summary-text-sngl01234567890",
},
},
Object {
Expand All @@ -2514,7 +2531,8 @@ Array [
"text": Symbol(contact-summary-row-contact),
},
"value": Object {
"text": "contact-summary-text-plrl01234567890",
"meta": "<meta name=\\"format-detection\\" content=\\"telephone=no\\">",
"text": "Text messages-contact-summary-text-plrl01234567890",
},
},
Object {
Expand Down
5 changes: 2 additions & 3 deletions packages/gafl-webapp-service/src/pages/summary/contact-summary/__tests__/route.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ const getMockCatalog = overrides => ({
contact_summary_row_contact: Symbol('contact-summary-row-contact'),
contact_summary_row_licence_details: Symbol('contact-summary-row-licence-details'),
contact_summary_row_newsletter: Symbol('contact-summary-row-newsletter'),
contact_summary_text_sngl: 'contact-summary-text-sngl',
contact_summary_text_plrl: 'contact-summary-text-plrl',
contact_summary_text_sngl: 'Text message-contact-summary-text-sngl',
contact_summary_text_plrl: 'Text messages-contact-summary-text-plrl',
contact_summary_title: Symbol('contact-summary-title'),
no: 'negative, Ghost Rider',
yes: 'aye',
Expand Down Expand Up @@ -169,7 +169,6 @@ describe('contact-summary > route', () => {
const mssgCatalog = getMockCatalog({
[mssgKey]: mssg
})
console.log('mssgcat: ', mssgCatalog.yes)
const samplePermission = getMockPermission({
preferredMethodOfNewsletter
})
Expand Down
7 changes: 6 additions & 1 deletion packages/gafl-webapp-service/src/pages/summary/contact-summary/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class RowGenerator {

_generateRow (label, text, rawHref, visuallyHiddenText, id) {
const href = addLanguageCodeToUri(this.request, rawHref)
return {
const row = {
key: {
text: label
},
Expand All @@ -90,6 +90,11 @@ class RowGenerator {
}
})
}
if (text.startsWith('Text message')) {
row.value.meta = '<meta name="format-detection" content="telephone=no">'
}

return row
}

generateStandardRow (label, text, rawHref, visuallyHiddenText, id) {
Expand Down
Loading