Create RP Record in CRM #2081
Merged
Create RP Record in CRM #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/IWTF-4262 After a successful payment, when the permission is provisioned, a RCP record should be created along with everything else. It shouldn't be created if the RCP toggle is off
… put transaction in a shape accepted by processRecurringPayment. Also modified processRecurringPayment to set publicId to be a hash of the recurring payment id
…o throw errors for invalid dates and refactored
…n be used by processRecurringPayment
…ther than using the permission embedded in the transaction, altered transaction queue processor to save RecurringPayment after Permission and Contact, removed contactId and activePermission fields as these were extraneous
irisfaraway
requested changes
Dec 9, 2024
| }) | ||
|
|
||
| describe('generateRecurringPaymentRecord', () => { | ||
| it.each([ |
There was a problem hiding this comment.
It's a recipe for suffering, I know, but could we have some tests for leap years and daylight savings?
There was a problem hiding this comment.
Good reminder, I'd meant to add these but then forgot
...ages/sales-api-service/src/services/transactions/__tests__/process-transaction-queue.spec.js
Outdated
Show resolved
Hide resolved
|
irisfaraway
requested changes
Dec 10, 2024
packages/sales-api-service/src/services/__tests__/recurring-payments.service.spec.js
Show resolved
Hide resolved
irisfaraway
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/IWTF-4262
After a successful payment, when the permission is provisioned, a RCP record should be created along with everything else. It shouldn't be created if the RCP toggle is off