Fix/ruby 2805 postcode validation #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brujeo
reviewed
Jan 11, 2024
flood_risk_engine.gemspec
Outdated
| @@ -36,6 +36,7 @@ Gem::Specification.new do |s| | |||
| # which details of the last email sent by the app can be accessed | |||
| s.add_dependency "defra_ruby_email", "~> 1" | |||
| s.add_dependency "defra_ruby_validators" | |||
| s.add_dependency "faraday-retry" | |||
There was a problem hiding this comment.
Shouldn't this be a Gemfile dependency?
There was a problem hiding this comment.
Perhaps. Do you mean just for :development?
There was a problem hiding this comment.
in my understanding, faraday is only used by changelog gem, which isn't used in the runtime
…ctiveJob configuration for unit testing
brujeo
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to use the new postcode validator from defra_ruby_validators
https://eaflood.atlassian.net/browse/RUBY-2805