Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSR-1370 | Fix ceremonial county search #892

Draft
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

neilbmclaughlin
Copy link
Contributor

  • FSR-1370 Fix county search
  • Initial set of changes to allow search of english ceremonial and administrative counties
  • Simplify postcode URIs
  • Remove unused isScotlandOrNorthernIsland flag

@neilbmclaughlin neilbmclaughlin force-pushed the fix/FSR-1370-fix-county-search branch 3 times, most recently from cf26ef7 to adb1b7d Compare December 17, 2024 11:26
As well as for aesthetic reasons this prevents scenarios where searching by the postcode and
returned name doesn't return the same result as the postcode alone. An example of this was postcode
TQ9 7SS which was reported in feedback
Also hard coded the isEngland flag as bing results are filtered to
exclude non-english results. This flag can also probably be removed next.
@neilbmclaughlin neilbmclaughlin force-pushed the fix/FSR-1370-fix-county-search branch from adb1b7d to 2885706 Compare December 17, 2024 14:10
Bing can handle most full postcodes with or without spaces between
the outcode and incode but some (?all) double digit outcodes seem
to present a problem (e.g. DE12 8EA vs DE128EA)
Types and precedance reflect discussions with PO during demo
This is to remove code duplication and also to allow different slug creation
behaviour based on entityType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant