-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSR-1370 | Fix ceremonial county search #892
Draft
neilbmclaughlin
wants to merge
9
commits into
development
Choose a base branch
from
fix/FSR-1370-fix-county-search
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neilbmclaughlin
commented
Dec 12, 2024
- FSR-1370 Fix county search
- Initial set of changes to allow search of english ceremonial and administrative counties
- Simplify postcode URIs
- Remove unused isScotlandOrNorthernIsland flag
neilbmclaughlin
force-pushed
the
fix/FSR-1370-fix-county-search
branch
3 times, most recently
from
December 17, 2024 11:26
cf26ef7
to
adb1b7d
Compare
…nistrative counties
As well as for aesthetic reasons this prevents scenarios where searching by the postcode and returned name doesn't return the same result as the postcode alone. An example of this was postcode TQ9 7SS which was reported in feedback
Also hard coded the isEngland flag as bing results are filtered to exclude non-english results. This flag can also probably be removed next.
neilbmclaughlin
force-pushed
the
fix/FSR-1370-fix-county-search
branch
from
December 17, 2024 14:10
adb1b7d
to
2885706
Compare
Bing can handle most full postcodes with or without spaces between the outcode and incode but some (?all) double digit outcodes seem to present a problem (e.g. DE12 8EA vs DE128EA)
Types and precedance reflect discussions with PO during demo
This is to remove code duplication and also to allow different slug creation behaviour based on entityType
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.