-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 8.9.0 #864
Closed
Closed
Release 8.9.0 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FSR-1237: Add logic to show trigger levels on target area page * FSR-1237: Add CSS for latest levels box * FSR-1237: Update the logic to not show the latest levels box for TAs with more than 4 thresholds * FSR-1237: Fix failing tests, update hyperlink text in target-area.html, and refactor code * FSR-1237: Add unit tests for latest levels box * FSR-1237: Fix SonarCloud issues and refactor code for improved quality * FSR-1237: Add logic to show 'levels unavailable' message for offline and suspended stations and fix tests * FSR-1237: Add unit tests for stations with different status * FSR-1237: Exclude Closed and Welsh stations with no data from latest levels display and add tests * FSR-1237: Refactor code to move HTML logic to the model and change the method name to en-UK spelling * FSR-1237: Fix css * FSR-1237: Fix console errors * FSR-1237: Update elapsed time formatting and tests * FSR-1237: Refactor code --------- Co-authored-by: nikiwycherley <[email protected]>
* FSR-1237: Fix spacing in 'LATEST LEVELS' * FSR-1237: Display '(National Resources Wales)' for Welsh stations in flood warnings and add test * FSR-1237: Update time display for closed/offline/suspended gauges * FSR-1237: Add fullstop for multiple gauges link * FSR-1237: Revert link back to original * FSR-1237: Ensure visibility of LATEST LEVEL in high-contrast mode by adjusting background and border styles * FSR-1237: Reinstate levels auto-update message and refactor unit tests for consistency * FSR-1237: Refactor adjustThresholdValue logic and add tests for threshold adjustment functionality in getThresholdsForTargetArea * FSR-1237: Replace adjustThresholdValue with processThreshold to avoid code repetition
…on TA Pages (#763) * FSR-1261: Improve visibility of map link and sign-up call to action on TA pages * FSR-1261: Change map button text colour to blue * FSR-1261: Change Icon on map button to be black * FSR-1261: Remove additional CSS to avoid duplication in upcoming merge
* FSR-1333: Consistent map button CSS * FSR-1333: Change map button text to blue and icon to black * FSR-1333: Refactor CSV download button styling for consistency with map buttons and fix tests * Typo fix
* FSR-1295: Display correct chart thresholds based on presence of TID in URL * FSR-1295: Exclude TID in URL for Welsh stations on the latest level links * FSR-1295: Add tests * FSR-1295: Refactor code and fix sonar clould issues * FSR-1295: Add logic to show correct value on chart for stations with stageDatum * Push * FSR-1295: Fix typo in test * Undo typo
* added links to flood warnings target areas in thresholds * altered logic for top of normal range and fixed unit tests * changed chart.js threshold references * fixed sonar issues * refactored code to reduce complexity for Sonarcloud * updated short name on thresholds to include name of flood warning area * removed incorrect capital letter * CSS fix to handle stations with historical threshold values * added process warning thresholds functions and tests * fixing sonar issues * fixed linting issue * sonar fix * fixed chart label and latest levels CSS * stopped displaying inactive warnings as thresholds * sonar fix * rejig of logic to show top of normal range * sonar fixes * altered value on top of normal range * sonar fix * changed top of normal range to 2dp * rejig of 2dp fix * altered id of top of normal range thresholds * roll back of _chart-controls.scss * added stage datum calculations to warnings * sonar fix * bring process threshold into it's own class * removed uneeded export * linting changes
* FSR-1294: Add logic to wrap text for the threshold label on the station chart * Lint Fix
* FSR-1261: Improve visibility of map link and sign-up call to action on TA pages * FSR-1261: Change map button text colour to blue * FSR-1261: Change Icon on map button to be black * FSR-1294: Add logic to wrap text for the threshold label on the station chart * auto refresh. updated TA tests * sonar fixes * some sonar fixes * added links to flood warnings target areas in thresholds * altered logic for top of normal range and fixed unit tests * changed chart.js threshold references * fixed sonar issues * refactored code to reduce complexity for Sonarcloud * updated short name on thresholds to include name of flood warning area * FSR-1333: Consistent map button CSS * FSR-1333: Change map button text to blue and icon to black * FSR-1261: Remove additional CSS to avoid duplication in upcoming merge * FSR-1333: Refactor CSV download button styling for consistency with map buttons and fix tests * FSR-1295: Display correct chart thresholds based on presence of TID in URL * removed incorrect capital letter * FSR-1295: Exclude TID in URL for Welsh stations on the latest level links * FSR-1295: Add tests * FSR-1295: Refactor code and fix sonar clould issues * refactor autorefresh. add unit tests * conditional callback * CSS fix to handle stations with historical threshold values * Fix/fsr 1237 latest level warning pages service (#844) * FSR-1237: Fix spacing in 'LATEST LEVELS' * FSR-1237: Display '(National Resources Wales)' for Welsh stations in flood warnings and add test * FSR-1237: Update time display for closed/offline/suspended gauges * FSR-1237: Add fullstop for multiple gauges link * FSR-1237: Revert link back to original * FSR-1237: Ensure visibility of LATEST LEVEL in high-contrast mode by adjusting background and border styles * FSR-1237: Reinstate levels auto-update message and refactor unit tests for consistency * FSR-1237: Refactor adjustThresholdValue logic and add tests for threshold adjustment functionality in getThresholdsForTargetArea * Feature/fsr 1261 update ta pay layout (#845) * FSR-1261: Improve visibility of map link and sign-up call to action on TA pages * FSR-1261: Change map button text colour to blue * FSR-1261: Change Icon on map button to be black * FSR-1261: Remove additional CSS to avoid duplication in upcoming merge * use <output> element * latest level refactor and unit tests * fix test * remove console logs * move update in to test * added process warning thresholds functions and tests * fixing sonar issues * fixed linting issue * sonar fix * fixed chart label and latest levels CSS * stopped displaying inactive warnings as thresholds * sonar fix * merged with FSR-1295 * rejig of logic to show top of normal range * sonar fixes * change to top of normal range value * altered value on top of normal range * sonar fix * changed top of normal range to 2dp * rejig of 2dp fix * altered id of top of normal range thresholds * roll back of _chart-controls.scss * reload on warning change * added stage datum calculations to warnings * sonar fix * bring process threshold into it's own class * removed uneeded export * fix for chart label * attempt at fixing auto refresh * logs * hour ago * update next hour update logic * updated render time ago to state over an hour after 59 mins not 60 * remove console logs --------- Co-authored-by: Keyurx11 <[email protected]> Co-authored-by: Ash <[email protected]> Co-authored-by: Keyurx11 <[email protected]>
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBC