FSR-530: Fix sonarclud issues during version update for TA update. (#283

)

Co-authored-by: John Shields <[email protected]>

server/models/views/river-and-sea-levels.js

@@ -230,7 +230,7 @@ class ViewModel {
     return ''
   }
 
-  typeChecked (types, type) {
+  typeChecked (_types, type) {
     return this.types.some(a => type.includes(a))
   }
 

server/routes/alerts-and-warnings.js

@@ -83,7 +83,7 @@ module.exports = [{
       payload: joi.object({
         location: joi.string().allow('').trim().max(200).required()
       }),
-      failAction: (request, h, err) => {
+      failAction: (request, h, _err) => {
         return h.view('alerts-and-warnings').takeover()
       }
     }

server/routes/guidance.js

@@ -1,7 +1,7 @@
 module.exports = {
   method: 'GET',
   path: '/what-to-do-in-a-flood',
-  handler: async (request, h) => {
+  handler: async (_request, h) => {
     return h.view('what-to-do-in-a-flood')
   }
 }

server/routes/river-and-sea-levels.js

@@ -78,7 +78,7 @@ module.exports = [{
         lyr: joi.string(),
         v: joi.string()
       }),
-      failAction: (request, h, err) => {
+      failAction: (request, h, _err) => {
         return h.view('404').code(404).takeover()
       }
     }

server/routes/start-page.js

@@ -3,6 +3,6 @@ module.exports = {
   path: '/start-page',
   options: {
     description: 'start-page - Permanent (HTTP 301) redirect to gov.uk/check-flooding',
-    handler: async (request, h) => h.redirect('https://www.gov.uk/check-flooding').code(301)
+    handler: async (_request, h) => h.redirect('https://www.gov.uk/check-flooding').code(301)
   }
 }

server/routes/status.js

@@ -6,7 +6,7 @@ const FloodsModel = require('../models/floods')
 module.exports = {
   method: 'GET',
   path: '/status',
-  handler: async (request, h) => {
+  handler: async (_request, h) => {
     // test location services
     let place, locationStart, locationEnd
     try {