Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BNGP-5498: Credits: Follow post-redirect-get pattern #897

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

BNGP-5498: Credits: Follow post-redirect-get pattern #897

wants to merge 19 commits into from

Conversation

thousand-leaves
Copy link
Collaborator

@thousand-leaves thousand-leaves commented Oct 10, 2024 •
edited
Loading

https://eaflood.atlassian.net/browse/BNGP-5498

This change implements the post-redirect-get pattern as best practice in order to avoid unwanted behaviours such as form re-submission and display of incorrect error message and data.

  • packages/webapp/src/plugins/redirect-view.js -> a plugin to redirect to the error view (post-redirect-get pattern)
  • packages/webapp/src/utils/redirect-view-handler.js -> a helper to add a boolean used by the above plugin (indicating that we want to return h.view following such a redirect).

Other changes are mostly where we implement the usage of the plugin when returning a view to display an error message following a form POST.

@thousand-leaves
BNGP-5498: Credits: Follow post-redirect-get pattern
898d6e9 
https://eaflood.atlassian.net/browse/BNGP-5498

This change implements the post-redirect-get pattern as best practice in order to avoid unwanted behaviours such as form re-submission and display of incorrect error message and data.
@thousand-leaves thousand-leaves self-assigned this Oct 10, 2024
@thousand-leaves
Add redirect-view.js, config and tests
d9b506d
@thousand-leaves
Refactor add-statutory-biodiversity-credits.js to use redirect view
dc04800
@thousand-leaves
Refactor server.js to add 'no-store' to Cache-Control header
67b0a5d
@thousand-leaves
Refactor check-defra-account-details.js to use redirect view
f0ec9fe
@thousand-leaves
Refactor check-metric-file.js to use redirect view
a3be46d
@thousand-leaves
Refactor middle-name.js to use redirect view
89bd755
@thousand-leaves
Refactor nationality.js to use redirect view
a485f01
@thousand-leaves
Refactor purchasing-individual-organisation.js to use redirect view
d47764e
@thousand-leaves
Refactor upload-metric-file.js to use redirect view
360b51d
@thousand-leaves
Refactor date-of-birth.js to use redirect view
cdb519f
@thousand-leaves
Refactor confirm-terms-conditions.js to use redirect view
cfce38f
@thousand-leaves
Refactor check-purchase-order.js to use redirect view
1f5c476
@thousand-leaves
Refactor development-project-information.js to use redirect view
8bb0c7e
@thousand-leaves
Fix failing test
7ad4781
@thousand-leaves
Fix template bug causing service to crash on check-purchase-order page
3a98998
@thousand-leaves
Refactor date-of-birth.js to fix bug causing service to crash
5e9ae2e
@thousand-leaves
Fix date-of-birth.js tests
e3ed443
@thousand-leaves
Fix bug on 'date-of-birth.js' causing form data to be wiped on error …
cbf1452 
…submission
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
98.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thousand-leaves thousand-leaves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thousand-leaves