-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BNGP-5491: Implement OAuth authentication #896
Draft
StuAA78
wants to merge
17
commits into
master
Choose a base branch
from
bngp-5491-oauth-authentication-spike
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StuAA78
changed the title
BNGP-5491: OAuth authentication spike
BNGP-5491: Implement OAuth authentication
Oct 31, 2024
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/BNGP-5491
This is a straightforward OAuth implementation using native JS. We're only authenticating the server with the backend API, and we've been advised that a simple token request is fine (ie. there's no need to use refresh tokens). Therefore we don't need all the additional code, dependencies etc. of a library when native code will work fine.
The following environment variables need to be set (eg. by adding them to
docker/WEBAPP_ENV
if running locally)OAUTH_CLIENT_ID
OAUTH_SCOPE
OAUTH_SECRET
OAUTH_TENANT_ID
USE_OAUTH
(set astrue
if OAuth is to be used)This implementation replaces
wreck.get
(which is being used in the one place where authentication is needed) withgetWithAuth()
. This handles fetching an auth token or using a cached one if it hasn't yet expired; and will then execute the requiredwreck.get
request (and will fetch a new token and retry if the request comes back unauthorised).Note that this implementation does not pass through any additional options to the
wreck.get
request; as it's only used in one place at present this isn't required. It will need to be expanded in future if this is required.