BNGP-5359: Content fixes v4 #858
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that these this page is common to both combined case and land journeys, so changing it for common case changes it for both. We go with the assumption that the v4 design of the page is how we would ideally want it throughout the service and therefore we're okay with it applying to both pages, rather than splitting the page into separate versions for each journey
StuAA78
force-pushed
the
bngp-5359-content-fixes-v4
branch
from
4a72318 to
22685f6
Compare
thousand-leaves
previously approved these changes
Sep 13, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/BNGP-5359
We apply various content fixes as detailed in the ticket.
One point to note is that AC1b makes a change to the "what to do if you have no written authorisation" section of the "Upload written authorisation" page. This page is common to both combined case and land journeys. We have therefore assumed that the v4 design of the page is how we would ideally want it throughout the service and therefore we're okay with it applying to both pages, rather than splitting the page into separate versions for each journey.
Also, several upload pages in the service are already in line with the desired changes specified in the ticket (ie. button text is renamed "Save and upload", and a "Save progress and come back later" link is added). This button block has therefore been moved into
common/save-and-upload-button-group.htmland the pages updated to include this. The exception is to thepackages/webapp/src/views/developer/upload-metric-file.htmlandpackages/webapp/src/views/combined-case/upload-allocation-metric.htmlpages; these have a different id for the button, so to avoid any potential issues with things that might rely on the id, these two pages have been left as-is.